Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to display custom error thrown from the changePassword action #620

Conversation

manojleaton
Copy link
Contributor

Fixes #BLUI-5969 .

Changes proposed in this Pull Request:

Screenshots / Screen Recording (if applicable)

To Test:

Any specific feedback you are looking for?

@github-actions github-actions bot added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Aug 7, 2024
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 8 lines in your changes missing coverage. Please review.

Project coverage is 72.44%. Comparing base (b01d186) to head (d3726a4).

Files Patch % Lines
...ents/ChangePasswordDialog/ChangePasswordDialog.tsx 40.00% 4 Missing and 2 partials ⚠️
.../ChangePasswordDialog/ChangePasswordDialogBase.tsx 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #620      +/-   ##
==========================================
- Coverage   72.76%   72.44%   -0.33%     
==========================================
  Files          86       86              
  Lines        1098     1107       +9     
  Branches      243      245       +2     
==========================================
+ Hits          799      802       +3     
- Misses        122      126       +4     
- Partials      177      179       +2     
Flag Coverage Δ
unittests 72.44% <42.85%> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeffGreiner-eaton
Copy link
Collaborator

same issues as before, react and types-react versions throwing warnings...
image

Copy link

github-actions bot commented Aug 8, 2024

Visit the preview URL for this PR (updated for commit d3726a4):

https://blui-react-login--pr620-bug-5969-unable-to-d-heqmj1c1.web.app

(expires Sun, 11 Aug 2024 12:04:23 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1e9064d2e35ed37fe01e053587ea5f209719a043

@ektaghag-eaton
Copy link
Contributor

Screenshot 2024-08-08 at 1 07 26 PM

it is working

Copy link
Contributor

@ektaghag-eaton ektaghag-eaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @manojleaton , please update changelog

@ektaghag-eaton ektaghag-eaton merged commit 491a282 into dev Aug 9, 2024
11 checks passed
@ektaghag-eaton ektaghag-eaton deleted the bug/5969-Unable-to-display-custom-error-thrown-from-the-changePassword-action branch August 9, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering
Development

Successfully merging this pull request may close these issues.

Unable to display custom error thrown from the changePassword action
4 participants