Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SX Style overrides do not work on full screens #619

Merged
merged 6 commits into from
Aug 9, 2024

Conversation

manojleaton
Copy link
Contributor

@manojleaton manojleaton commented Aug 5, 2024

Fixes #BLUI-5975 .

Changes proposed in this Pull Request:

Screenshots / Screen Recording (if applicable)

To Test:

  • Pass styles to any of the full screen components and verify
  • Example:
    sx={{ backgroundColor: 'orange', '& .MuiCardContent-root':{ backgroundColor: 'red', '::-webkit-scrollbar': { width: 0 } } }}

Any specific feedback you are looking for?

@github-actions github-actions bot added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Aug 5, 2024
@JeffGreiner-eaton
Copy link
Collaborator

the example doesn't run unless you pass placeholder={undefined} onPointerEnterCapture={undefined} onPointerLeaveCapture={undefined} for Drawer, DrawerNavGroup, DrawerBody...etc in exampleHome component

@ektaghag-eaton
Copy link
Contributor

the example doesn't run unless you pass placeholder={undefined} onPointerEnterCapture={undefined} onPointerLeaveCapture={undefined} for Drawer, DrawerNavGroup, DrawerBody...etc in exampleHome component

This issue might be because of 77c1e27. @manojleaton can you try to revert and test on local?

Copy link

github-actions bot commented Aug 6, 2024

Visit the preview URL for this PR (updated for commit cdeead7):

https://blui-react-login--pr619-bug-5975-fix-react-w-4607isu9.web.app

(expires Sat, 10 Aug 2024 11:15:10 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1e9064d2e35ed37fe01e053587ea5f209719a043

@JeffGreiner-eaton
Copy link
Collaborator

I was looking at the unit tests and if I run yarn test we have tests failing around the workflowcards and props but if I run each test individually the tests pass, weird. Also notice some tests failing on login, okta and several others. I'm not sure whats been updated to cause this but some tests having issues.

image
image
image
image

@ektaghag-eaton
Copy link
Contributor

I was looking at the unit tests and if I run yarn test we have tests failing around the workflowcards and props but if I run each test individually the tests pass, weird. Also notice some tests failing on login, okta and several others. I'm not sure whats been updated to cause this but some tests having issues.

image image image image

Might be because of this commit fabda4b. will check with Manoj and Update PR.

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.76%. Comparing base (26048c4) to head (cdeead7).

Files Patch % Lines
...ns/ResetPasswordScreen/ResetPasswordScreenBase.tsx 0.00% 0 Missing and 1 partial ⚠️
...ow/src/screens/SuccessScreen/SuccessScreenBase.tsx 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #619      +/-   ##
==========================================
- Coverage   73.58%   72.76%   -0.82%     
==========================================
  Files          86       86              
  Lines        1098     1098              
  Branches      243      243              
==========================================
- Hits          808      799       -9     
- Misses        115      122       +7     
- Partials      175      177       +2     
Flag Coverage Δ
unittests 72.76% <33.33%> (-0.82%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@manojleaton manojleaton merged commit b01d186 into dev Aug 9, 2024
11 checks passed
@manojleaton manojleaton deleted the bug/5975-Fix-React-workflow-issue branch August 9, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering
Development

Successfully merging this pull request may close these issues.

3 participants