-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SX Style overrides do not work on full screens #619
Conversation
the example doesn't run unless you pass placeholder={undefined} onPointerEnterCapture={undefined} onPointerLeaveCapture={undefined} for Drawer, DrawerNavGroup, DrawerBody...etc in exampleHome component |
This issue might be because of 77c1e27. @manojleaton can you try to revert and test on local? |
Visit the preview URL for this PR (updated for commit cdeead7): https://blui-react-login--pr619-bug-5975-fix-react-w-4607isu9.web.app (expires Sat, 10 Aug 2024 11:15:10 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 1e9064d2e35ed37fe01e053587ea5f209719a043 |
I was looking at the unit tests and if I run |
Might be because of this commit fabda4b. will check with Manoj and Update PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #619 +/- ##
==========================================
- Coverage 73.58% 72.76% -0.82%
==========================================
Files 86 86
Lines 1098 1098
Branches 243 243
==========================================
- Hits 808 799 -9
- Misses 115 122 +7
- Partials 175 177 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Fixes #BLUI-5975 .
Changes proposed in this Pull Request:
Screenshots / Screen Recording (if applicable)
To Test:
sx={{ backgroundColor: 'orange', '& .MuiCardContent-root':{ backgroundColor: 'red', '::-webkit-scrollbar': { width: 0 } } }}
Any specific feedback you are looking for?