-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug/5466 Update JSDocs in React Login Workflow #581
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #581 +/- ##
==========================================
- Coverage 72.38% 72.31% -0.07%
==========================================
Files 82 83 +1
Lines 1050 1051 +1
Branches 234 235 +1
==========================================
Hits 760 760
Misses 120 120
- Partials 170 171 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Visit the preview URL for this PR (updated for commit b9ae551): https://blui-react-login--pr581-bug-5466-updatejsdoc-us5ea8g8.web.app (expires Sat, 27 Apr 2024 07:14:39 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 1e9064d2e35ed37fe01e053587ea5f209719a043 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add jsdocs for below:
https://github.com/etn-ccis/blui-react-workflows/blob/bug/5680_typeDocs/login-workflow/src/components/WorkflowCard/Utility.ts (for all type definitions)
https://github.com/etn-ccis/blui-react-workflows/blob/bug/5680_typeDocs/login-workflow/src/contexts/AuthContext/context.ts#L8 (refer RN workflow)
can you recheck all files in context folder?
Fixes #5466
Changes proposed in this Pull Request:
-Update all of the JS Docs comments in React Workflows to match the format in RN
Screenshots / Screen Recording (if applicable)
To Test:
Any specific feedback you are looking for?