Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/5466 Update JSDocs in React Login Workflow #581

Merged
merged 9 commits into from
Apr 25, 2024

Conversation

priyankakmEaton
Copy link
Contributor

Fixes #5466

Changes proposed in this Pull Request:

-Update all of the JS Docs comments in React Workflows to match the format in RN

  1. Components
  2. Screens
  3. ContextProviders
  4. Hooks

Screenshots / Screen Recording (if applicable)

To Test:

Any specific feedback you are looking for?

@github-actions github-actions bot added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Apr 24, 2024
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.31%. Comparing base (8cbece5) to head (3e83bd1).
Report is 8 commits behind head on dev.

❗ Current head 3e83bd1 differs from pull request most recent head b9ae551. Consider uploading reports for the commit b9ae551 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #581      +/-   ##
==========================================
- Coverage   72.38%   72.31%   -0.07%     
==========================================
  Files          82       83       +1     
  Lines        1050     1051       +1     
  Branches      234      235       +1     
==========================================
  Hits          760      760              
  Misses        120      120              
- Partials      170      171       +1     
Flag Coverage Δ
unittests 72.31% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Apr 24, 2024

Visit the preview URL for this PR (updated for commit b9ae551):

https://blui-react-login--pr581-bug-5466-updatejsdoc-us5ea8g8.web.app

(expires Sat, 27 Apr 2024 07:14:39 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1e9064d2e35ed37fe01e053587ea5f209719a043

Copy link
Contributor

@ektaghag-eaton ektaghag-eaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@ektaghag-eaton ektaghag-eaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ektaghag-eaton ektaghag-eaton merged commit 017bdcd into dev Apr 25, 2024
6 checks passed
@ektaghag-eaton ektaghag-eaton deleted the bug/5466_updateJSdocs branch April 25, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering
Development

Successfully merging this pull request may close these issues.

2 participants