-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove workflowFinishState #577
Conversation
Visit the preview URL for this PR (updated for commit 3fdd34b): https://blui-react-login--pr577-bug-5681-removeworkf-zb2b943l.web.app (expires Fri, 26 Apr 2024 12:13:47 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 1e9064d2e35ed37fe01e053587ea5f209719a043 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to update ForgotPasswordScreen, ResetPasswordScreen etc.. similar to https://github.com/etn-ccis/blui-react-native-workflows/pull/444/files#diff-0add99f28485696a5d5a9a93437d776378508625c2a7ecb1e58f7f13edf50e9d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last change - we need to update docs where we have used this props.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #577 +/- ##
==========================================
+ Coverage 72.35% 72.38% +0.02%
==========================================
Files 83 82 -1
Lines 1049 1050 +1
Branches 234 234
==========================================
+ Hits 759 760 +1
Misses 120 120
Partials 170 170
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This looks good. Do we know why the unit test coverage dropped for EULA screen or the difference in codecov patch being 66% and dev at 72%? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other things look good.
Fixes #5681
Changes proposed in this Pull Request:
Screenshots / Screen Recording (if applicable)
To Test:
Any specific feedback you are looking for?