Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove workflowFinishState #577

Merged
merged 7 commits into from
Apr 24, 2024
Merged

Conversation

priyankakmEaton
Copy link
Contributor

@priyankakmEaton priyankakmEaton commented Apr 16, 2024

Fixes #5681

Changes proposed in this Pull Request:

  • Remove the WorkflowCardFinishState component — this is an unnecessary wrapper component
  • Move the EmptyState inline on the success screens
  • add EmptyState props to successScreens

Screenshots / Screen Recording (if applicable)

To Test:

Any specific feedback you are looking for?

@github-actions github-actions bot added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Apr 16, 2024
Copy link

github-actions bot commented Apr 16, 2024

Visit the preview URL for this PR (updated for commit 3fdd34b):

https://blui-react-login--pr577-bug-5681-removeworkf-zb2b943l.web.app

(expires Fri, 26 Apr 2024 12:13:47 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1e9064d2e35ed37fe01e053587ea5f209719a043

@JeffGreiner-eaton
Copy link
Collaborator

When last screen of registration loads (success screen) we throw error here
image
image

Copy link
Contributor

@ektaghag-eaton ektaghag-eaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ektaghag-eaton ektaghag-eaton self-requested a review April 19, 2024 10:20
Copy link
Contributor

@ektaghag-eaton ektaghag-eaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last change - we need to update docs where we have used this props.

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 72.38%. Comparing base (8bb6570) to head (8cbece5).
Report is 7 commits behind head on dev.

❗ Current head 8cbece5 differs from pull request most recent head 3fdd34b. Consider uploading reports for the commit 3fdd34b to get more accurate results

Files Patch % Lines
...ow/src/screens/SuccessScreen/SuccessScreenBase.tsx 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #577      +/-   ##
==========================================
+ Coverage   72.35%   72.38%   +0.02%     
==========================================
  Files          83       82       -1     
  Lines        1049     1050       +1     
  Branches      234      234              
==========================================
+ Hits          759      760       +1     
  Misses        120      120              
  Partials      170      170              
Flag Coverage Δ
unittests 72.38% <66.66%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeffGreiner-eaton
Copy link
Collaborator

This looks good. Do we know why the unit test coverage dropped for EULA screen or the difference in codecov patch being 66% and dev at 72%?

Copy link
Collaborator

@surajeaton surajeaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other things look good.

@surajeaton surajeaton merged commit fd8a8a2 into dev Apr 24, 2024
6 checks passed
@surajeaton surajeaton deleted the bug/5681_removeWorkflowFinishState branch April 24, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering
Development

Successfully merging this pull request may close these issues.

4 participants