Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix translate dialog button #557

Merged
merged 7 commits into from
Mar 8, 2024

Conversation

JeffGreiner-eaton
Copy link
Collaborator

@JeffGreiner-eaton JeffGreiner-eaton commented Mar 5, 2024

Fixes #543.

Changes proposed in this Pull Request:

  • update error manger to translate dismiss button label

Screenshots / Screen Recording (if applicable)

image
image
image

To Test:

-clone and git checkout fix/blui-5378-translate-dialog-button

  • update line 14 in AuthUIAction to return true;
  • update example Login screen with mode: ‘dialog’
  • yarn start:example
  • click debug and switch language
  • enter credentials click login
  • translation error displays in dialog with translated button

Any specific feedback you are looking for?

@github-actions github-actions bot added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Mar 5, 2024
Copy link

github-actions bot commented Mar 5, 2024

Visit the preview URL for this PR (updated for commit 7dd2edb):

https://blui-react-login--pr557-fix-blui-5378-transl-mbgug0sy.web.app

(expires Sat, 09 Mar 2024 20:07:59 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1e9064d2e35ed37fe01e053587ea5f209719a043

@JeffGreiner-eaton JeffGreiner-eaton marked this pull request as ready for review March 7, 2024 18:46
@JeffGreiner-eaton JeffGreiner-eaton changed the title Fix/blui 5378 translate dialog button Fix translate dialog button Mar 7, 2024
Copy link
Collaborator

@surajeaton surajeaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Only the pipeline is failing.

@ektaghag-eaton
Copy link
Contributor

Rerun the pipeline.

@ektaghag-eaton ektaghag-eaton merged commit 5a807c3 into dev Mar 8, 2024
7 checks passed
@ektaghag-eaton ektaghag-eaton deleted the fix/blui-5378-translate-dialog-button branch March 8, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering
Development

Successfully merging this pull request may close these issues.

Hardcoded dismissible Dialog button text
3 participants