Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove react router dom from types #551

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

JeffGreiner-eaton
Copy link
Collaborator

Fixes #546.

Changes proposed in this Pull Request:

  • remove react router dom from AuthContext & RegistrationContext
  • update example

Screenshots / Screen Recording (if applicable)

To Test:

Any specific feedback you are looking for?

@github-actions github-actions bot added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Feb 27, 2024
Copy link

Visit the preview URL for this PR (updated for commit 4be3218):

https://blui-react-login--pr551-fix-blui-5377-remove-5x4ypq24.web.app

(expires Thu, 29 Feb 2024 20:52:57 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1e9064d2e35ed37fe01e053587ea5f209719a043

Copy link
Collaborator

@surajeaton surajeaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Collaborator

@surajeaton surajeaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to remove react-router-dom and types of dev dependencies?

@JeffGreiner-eaton
Copy link
Collaborator Author

Do we need to remove react-router-dom and types of dev dependencies?

I dont think, auth/ guest guard and other workflow items using useNavigate

@JeffGreiner-eaton JeffGreiner-eaton merged commit e6b2390 into dev Feb 29, 2024
10 checks passed
@JeffGreiner-eaton JeffGreiner-eaton deleted the fix/blui-5377-remove-dependency branch February 29, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering
Development

Successfully merging this pull request may close these issues.

Fix dependency on react-router
2 participants