Add BLCSelfRegistrationSuccessScreen #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daileytj
requested review from
surajeaton,
ektaghag-eaton and
JeffGreiner-eaton
as code owners
github-actions
bot
added
the
brightlayer-ui
|
Visit the preview URL for this PR (updated for commit 9cfc21b): https://blui-react-login--pr533-feature-blui-4851-se-the8ugx2.web.app (expires Sun, 17 Dec 2023 15:44:13 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 1e9064d2e35ed37fe01e053587ea5f209719a043 |
ektaghag-eaton
approved these changes
Dec 19, 2023
ektaghag-eaton
deleted the
feature/blui-4851-self-registration-success-screen
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes BLUI-4851.
Changes proposed in this Pull Request:
Screenshots / Screen Recording (if applicable)
To Test:
Any specific feedback you are looking for?
notes: There is functionality that will need to go into this once the rest of workflow is complete that cannot be done now. I left
@todocomments for the things that will need changed and can write a followup story to this one so that it can be tracked.I opted to use the design encouraged by our SuccessScreenBase so the title text is centered instead of left aligned and the space about the icons is greater than in the seed-ui Image.
I also decided to remove the button that was permanently disabled in the seed-ui. We can add the button in the future if/when the additional functionality is implemented.