Add new org screen full #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daileytj
requested review from
surajeaton,
ektaghag-eaton and
JeffGreiner-eaton
as code owners
github-actions
bot
added
the
brightlayer-ui
|
Visit the preview URL for this PR (updated for commit 782184d): https://blui-react-login--pr528-feature-create-new-o-rqv8rm1o.web.app (expires Thu, 07 Dec 2023 20:16:02 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 1e9064d2e35ed37fe01e053587ea5f209719a043 |
login-workflow/src/contexts/RegistrationContext/RegistrationDictionaries/english.ts
Show resolved
Hide resolved
login-workflow/src/screens/CreateNewOrgScreen/CreateNewOrgScreen.tsx
Outdated
Show resolved
Hide resolved
surajeaton
reviewed
Dec 5, 2023
There was a problem hiding this comment.
-
The site options base screen also has the same icon and a few tweaks in the message. (text below icon). We have an icon and message prop instead of an instruction prop.
https://github.com/etn-ccis/blui-react-workflows/blob/release/derms-auth-workflow/login-workflow/src/screens/SiteOptionsScreen/SiteOptionsScreenBase.tsx#L67 -
Need to update readme for this component.
| @@ -0,0 +1,29 @@ | |||
| # CreateAccountScreen | |||
|
|
|||
| A screen that displays a text field to collect tan organization name. The CreateNewOrgScreen must be used within a `RegistrationContextProvider`. | |||
There was a problem hiding this comment.
just typo here... tan organization
ektaghag-eaton
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes BLUI-4848.
Changes proposed in this Pull Request:
Screenshots / Screen Recording (if applicable)
To Test:
Any specific feedback you are looking for?