Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error manager title #526

Merged
merged 3 commits into from
Dec 4, 2023
Merged

Fix error manager title #526

merged 3 commits into from
Dec 4, 2023

Conversation

JeffGreiner-eaton
Copy link
Collaborator

@JeffGreiner-eaton JeffGreiner-eaton commented Dec 1, 2023

Fixes # .
#520 (review)

Changes proposed in this Pull Request:

  • update error manager to have title prop
  • update dialogConfig & messageBoxConfig to optionally use title string
  • update API table

Screenshots / Screen Recording (if applicable)

To Test:

  • clone and git checkout fix/error-manager-title
  • update line 14 in AuthUIAction to return true;
  • yarn start:example
  • enter credentials click login
  • error displays
  • update example Login screen with
<LoginScreen
        projectImage={<img src={EatonLogo} alt="logo" style={{ maxHeight: 80 }} />}
        header={<DebugComponent />}
        errorDisplayConfig={{
            mode: 'message-box',
            title: ‘My Custom Title',
            messageBoxConfig: {
                dismissible: true,
                position: 'top',
            },
        }}
    />
);
  • enter credentials click login
  • My Custom Title displays
  • update Login Screen mode: 'dialog',
  • enter credentials click login
  • My Custom Title displays

Any specific feedback you are looking for?

@github-actions github-actions bot added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Dec 1, 2023
Copy link

github-actions bot commented Dec 1, 2023

Visit the preview URL for this PR (updated for commit 5d38135):

https://blui-react-login--pr526-fix-error-manager-ti-icuhy9oa.web.app

(expires Sun, 03 Dec 2023 18:36:01 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1e9064d2e35ed37fe01e053587ea5f209719a043

@daileytj
Copy link
Contributor

daileytj commented Dec 1, 2023

@JeffGreiner-eaton can you add the issue or comment related to this for context?

@JeffGreiner-eaton
Copy link
Collaborator Author

@JeffGreiner-eaton can you add the issue or comment related to this for context?

#520 (review)

Copy link
Contributor

@ektaghag-eaton ektaghag-eaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working fine

@ektaghag-eaton ektaghag-eaton merged commit 43aca06 into dev Dec 4, 2023
7 checks passed
@ektaghag-eaton ektaghag-eaton deleted the fix/error-manager-title branch December 4, 2023 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering
Development

Successfully merging this pull request may close these issues.

3 participants