Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Site Optios base screen #512

Conversation

ektaghag-eaton
Copy link
Contributor

@ektaghag-eaton ektaghag-eaton commented Nov 8, 2023

Fixes 4845 .

Changes proposed in this Pull Request:

  • Add a new base screen
  • Update readme with API (need to update usage and image once the final screen is done)

Screenshots / Screen Recording (if applicable)

Screenshot 2023-11-15 at 6 14 39 PM

To Test:

Any specific feedback you are looking for?

@github-actions github-actions bot added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Nov 8, 2023
Copy link

github-actions bot commented Nov 8, 2023

Visit the preview URL for this PR (updated for commit b8a64b5):

https://blui-react-login--pr512-feature-blui-4845-si-srunt89b.web.app

(expires Thu, 23 Nov 2023 06:54:36 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1e9064d2e35ed37fe01e053587ea5f209719a043

@ektaghag-eaton
Copy link
Contributor Author

Hi @daileytj and @JeffGreiner-eaton please review.

@JeffGreiner-eaton
Copy link
Collaborator

JeffGreiner-eaton commented Nov 16, 2023

screens in both themes look good with enabled & disabled buttons...Just see comment above.
Also I didn't dig in to why the message content has like a onFocus set so it looks like its clickable

image

  • notice the divider changing weight here or my eyes playing tricks on me...
    image

@ektaghag-eaton
Copy link
Contributor Author

  • changing weight here or my eyes playing tricks on me.

How can I reproduce this? Did you disable both buttons?

@ektaghag-eaton
Copy link
Contributor Author

screens in both themes look good with enabled & disabled buttons...Just see comment above. Also I didn't dig in to why the message content has like a onFocus set so it looks like its clickable

image

  • notice the divider changing weight here or my eyes playing tricks on me...
    image
  • Fixed Onfocus issue
  • I am able to see the divider in all conditions
Screenshot 2023-11-20 at 11 22 44 AM Screenshot 2023-11-20 at 11 23 08 AM

@daileytj
Copy link
Contributor

You have some merge conflicts now so be sure to resolve those. Could you update your demo to match the pattern I've set up for the CreateNewOrgBaseScreen? This away it'll be easy to demo and test. This also keeps the repo and example clean since we can rip out all of the demos from one place at the end.

@ektaghag-eaton
Copy link
Contributor Author

You have some merge conflicts now so be sure to resolve those. Could you update your demo to match the pattern I've set up for the CreateNewOrgBaseScreen? This away it'll be easy to demo and test. This also keeps the repo and example clean since we can rip out all of the demos from one place at the end.

@daileytj Added a new URL for demo. Please review.

@ektaghag-eaton ektaghag-eaton merged commit 6c86dc5 into release/derms-auth-workflow Nov 22, 2023
7 checks passed
@ektaghag-eaton ektaghag-eaton deleted the feature/blui-4845-site-optios-base-screen branch November 22, 2023 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering
Development

Successfully merging this pull request may close these issues.

5 participants