-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Site Optios base screen #512
Add Site Optios base screen #512
Conversation
Visit the preview URL for this PR (updated for commit b8a64b5): https://blui-react-login--pr512-feature-blui-4845-si-srunt89b.web.app (expires Thu, 23 Nov 2023 06:54:36 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 1e9064d2e35ed37fe01e053587ea5f209719a043 |
login-workflow/src/screens/SiteOptionsScreen/SiteOptionsScreenBase.tsx
Outdated
Show resolved
Hide resolved
login-workflow/src/screens/SiteOptionsScreen/SiteOptionsScreenBase.tsx
Outdated
Show resolved
Hide resolved
Hi @daileytj and @JeffGreiner-eaton please review. |
How can I reproduce this? Did you disable both buttons? |
You have some merge conflicts now so be sure to resolve those. Could you update your demo to match the pattern I've set up for the CreateNewOrgBaseScreen? This away it'll be easy to demo and test. This also keeps the repo and example clean since we can rip out all of the demos from one place at the end. |
login-workflow/src/screens/SiteOptionsScreen/SiteOptionsScreenBase.tsx
Outdated
Show resolved
Hide resolved
…ccis/blui-react-workflows into feature/blui-4845-site-optios-base-screen
@daileytj Added a new URL for demo. Please review. |
Fixes 4845 .
Changes proposed in this Pull Request:
Screenshots / Screen Recording (if applicable)
To Test:
Any specific feedback you are looking for?