Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/change password padding #487

Merged
merged 4 commits into from
Sep 27, 2023
Merged

Fix/change password padding #487

merged 4 commits into from
Sep 27, 2023

Conversation

ektaghag-eaton
Copy link
Contributor

@ektaghag-eaton ektaghag-eaton commented Sep 27, 2023

Fixes # .

Changes proposed in this Pull Request:

  • Change Password Padding Fix
  • Fix Slots and SlotProps

Screenshots / Screen Recording (if applicable)

To Test:

  • Update Change password dialog in example with following code
    <ChangePasswordDialog
    open={app.showChangePasswordDialog}
    onPrevious={(): void => app.setShowChangePasswordDialog(false)}
    onSubmit={(): void => app.setShowChangePasswordDialog(false)}
    onFinish={(): void => logOut()}
    slots={{
    SuccessScreen: (props): JSX.Element => (

    {props?.icon}
    {props?.messageTitle}

    ),
    }}
    slotProps={{
    SuccessScreen: {
    icon: ,
    messageTitle: 'Yeah',
    message: 'ee',
    },
    }}
    />

Any specific feedback you are looking for?

@github-actions github-actions bot added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Sep 27, 2023
@github-actions
Copy link

Visit the preview URL for this PR (updated for commit b76f416):

https://blui-react-login--pr487-fix-change-password-kty9mr01.web.app

(expires Fri, 29 Sep 2023 07:52:24 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1e9064d2e35ed37fe01e053587ea5f209719a043

Copy link
Collaborator

@surajeaton surajeaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@surajeaton surajeaton merged commit 30b0ede into dev Sep 27, 2023
@surajeaton surajeaton deleted the fix/change-password-padding branch September 27, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering
Development

Successfully merging this pull request may close these issues.

2 participants