-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/4714 update validate user registration request return type #482
Feature/4714 update validate user registration request return type #482
Conversation
Visit the preview URL for this PR (updated for commit 83269f0): https://blui-react-login--pr482-feature-4714-update-tkrz9uau.web.app (expires Sat, 23 Sep 2023 14:43:33 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 1e9064d2e35ed37fe01e053587ea5f209719a043 |
when I set return { codeValid: true, accountExists: true }; I get account created. invite.mov |
accountExists: true should show ExistingAccountSuccessScreen. The attached video is following the correct scenario. accountExists: true should always show ExistingAccountSuccessScreen regardless the value of ** codeValid** |
when return { codeValid: false, accountExists: true }; invite2.mov |
@JeffGreiner-eaton Fixed this issue. Please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
codeValid, accountExists and string looks good
Fixes # BLUI-4714
Changes proposed in this Pull Request:
Screenshots / Screen Recording (if applicable)
{ codeValid: true, accountExists: false }
accountExists
has more preference overcodeValid
Invite Registration
Screen.Recording.2023-09-21.at.12.48.56.PM.mov
Self Registration
Screen.Recording.2023-09-21.at.2.08.19.PM.mov
To Test:
Any specific feedback you are looking for?
accountExists
has more preference overcodeValid