Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/4714 update validate user registration request return type #482

Merged

Conversation

surajeaton
Copy link
Collaborator

Fixes # BLUI-4714

Changes proposed in this Pull Request:

  • Updated validateUserRegistrationRequest action to return boolean or string
  • Updated account already exists screen logic
  • Updated code verify logic for both self / invite register

Screenshots / Screen Recording (if applicable)

  • To test please change the return value from validateUserRegistrationRequest { codeValid: true, accountExists: false }
  1. Passing accountExists as true ---> Should show account already exists success screen
  2. Passing codeValid as false or string ---> Should show error dialog
  3. accountExists has more preference over codeValid

Invite Registration

Screen.Recording.2023-09-21.at.12.48.56.PM.mov

Self Registration

Screen.Recording.2023-09-21.at.2.08.19.PM.mov

To Test:

  • cd login-workflow
  • Change the return values of validateUserRegistrationRequest

Any specific feedback you are looking for?

  1. Passing accountExists as true ---> Should show account already exists success screen
  2. Passing codeValid as false or string ---> Should show error dialog
  3. accountExists has more preference over codeValid

@github-actions github-actions bot added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Sep 21, 2023
@github-actions
Copy link

github-actions bot commented Sep 21, 2023

Visit the preview URL for this PR (updated for commit 83269f0):

https://blui-react-login--pr482-feature-4714-update-tkrz9uau.web.app

(expires Sat, 23 Sep 2023 14:43:33 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1e9064d2e35ed37fe01e053587ea5f209719a043

@JeffGreiner-eaton
Copy link
Collaborator

JeffGreiner-eaton commented Sep 21, 2023

when I set return { codeValid: true, accountExists: true }; I get account created.

invite.mov

@surajeaton
Copy link
Collaborator Author

when I set return { codeValid: true, accountExists: true }; I get account created.

invite.mov

accountExists: true should show ExistingAccountSuccessScreen. The attached video is following the correct scenario.

accountExists: true should always show ExistingAccountSuccessScreen regardless the value of ** codeValid**

@JeffGreiner-eaton
Copy link
Collaborator

when return { codeValid: false, accountExists: true };

invite2.mov

@joebochill joebochill self-assigned this Sep 21, 2023
@surajeaton
Copy link
Collaborator Author

when return { codeValid: false, accountExists: true };

invite2.mov

@JeffGreiner-eaton Fixed this issue. Please review.

Copy link
Collaborator

@JeffGreiner-eaton JeffGreiner-eaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codeValid, accountExists and string looks good

@surajeaton surajeaton merged commit b56826d into dev Sep 22, 2023
2 checks passed
@surajeaton surajeaton deleted the feature/4714-update-validateUserRegistrationRequest-return-type branch September 22, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering
Development

Successfully merging this pull request may close these issues.

3 participants