Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset Passoword: Fix showSuccessScreen, slotProps, slots props #480

Merged
merged 10 commits into from
Sep 27, 2023

Conversation

manojleaton
Copy link
Contributor

Fixes #BLUI-4701 .

Changes proposed in this Pull Request:

  • Added code changes for ResetPasswordScreen's showSuccessScreen, slots, slotprops

Screenshots / Screen Recording (if applicable)

Screenshot 2023-09-20 at 4 57 41 PM

To Test:

  • yarn start:example
  • Pass showSuccessScreen, slots, slotProps to ResetPasswordScreen from AppRouter.

Any specific feedback you are looking for?

@github-actions github-actions bot added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Sep 20, 2023
@github-actions
Copy link

github-actions bot commented Sep 20, 2023

Visit the preview URL for this PR (updated for commit 9ae57dd):

https://blui-react-login--pr480-4701-reset-passwor-fnrku27x.web.app

(expires Fri, 29 Sep 2023 07:41:34 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1e9064d2e35ed37fe01e053587ea5f209719a043

Copy link
Collaborator

@surajeaton surajeaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the failing test cases

Copy link
Collaborator

@surajeaton surajeaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@surajeaton surajeaton merged commit 414c646 into dev Sep 27, 2023
@surajeaton surajeaton deleted the 4701---reset-password-screen-fixes branch September 27, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering
Development

Successfully merging this pull request may close these issues.

2 participants