Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/bl UI 4704 create password prop #479

Merged
merged 6 commits into from
Sep 22, 2023

Conversation

ektaghag-eaton
Copy link
Contributor

Fixes 4704 .

Changes proposed in this Pull Request:

  • Enabled next button initialNewPasswordValue and initialConfirmPasswordValue is already set
  • Show an error when the password is not matched on the first load.

Screenshots / Screen Recording (if applicable)

  • Enabled next button initialNewPasswordValue and initialConfirmPasswordValue is already set
Screenshot 2023-09-20 at 3 30 39 PM - Show an error when the password is not matched on the first load. Screenshot 2023-09-20 at 3 30 16 PM

To Test:

Any specific feedback you are looking for?

@github-actions github-actions bot added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Sep 20, 2023
Copy link
Collaborator

@surajeaton surajeaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prettier is faling.
Please run yarn prettier

Copy link
Contributor

@daileytj daileytj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just be sure to remove the test code prior to merging

Copy link
Collaborator

@surajeaton surajeaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the failing test cases.

@ektaghag-eaton
Copy link
Contributor Author

Please fix the failing test cases.

Hi @surajeaton, I have fixed the test cases.

Copy link
Collaborator

@JeffGreiner-eaton JeffGreiner-eaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just update appRouter

Copy link
Collaborator

@surajeaton surajeaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please undo the changes for testing.
Also, there are wrong js doc for both create password and base screen (referring to contact support screen), please update those.

@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 358db7c):

https://blui-react-login--pr479-fix-blui-4704-create-bua06zn2.web.app

(expires Sat, 23 Sep 2023 16:21:59 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1e9064d2e35ed37fe01e053587ea5f209719a043

@ektaghag-eaton ektaghag-eaton merged commit a80b0b9 into dev Sep 22, 2023
2 checks passed
@ektaghag-eaton ektaghag-eaton deleted the fix/BLUI-4704-createPassword-prop branch September 22, 2023 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering
Development

Successfully merging this pull request may close these issues.

4 participants