Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/4706 change pw dialog props #476

Merged
merged 3 commits into from
Sep 18, 2023
Merged

Conversation

ektaghag-eaton
Copy link
Contributor

Fixes 4706 .

Changes proposed in this Pull Request:

  • fix currentPasswordChange, loading prop

Screenshots / Screen Recording (if applicable)

To Test:

  • you can use this code snippet in login-workflow/example/src/components/ChangePassword.tsx
    <ChangePasswordDialog currentPasswordChange={(currentPassword: string) => { console.log('Print Current Password', currentPassword); }} loading={false} open={app.showChangePasswordDialog} onPrevious={(): void => app.setShowChangePasswordDialog(false)} onSubmit={(): void => app.setShowChangePasswordDialog(false)} onFinish={(): void => logOut()} />

Any specific feedback you are looking for?

@github-actions github-actions bot added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Sep 13, 2023
Copy link
Collaborator

@surajeaton surajeaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the conflicts.

Copy link
Collaborator

@surajeaton surajeaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the conflicts.

@github-actions
Copy link

Visit the preview URL for this PR (updated for commit a4591d4):

https://blui-react-login--pr476-fix-4706-change-pw-d-alg8b2e8.web.app

(expires Mon, 18 Sep 2023 05:49:21 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1e9064d2e35ed37fe01e053587ea5f209719a043

@ektaghag-eaton
Copy link
Contributor Author

Please resolve the conflicts.

Done @surajeaton , please review.

Copy link
Contributor

@daileytj daileytj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@daileytj daileytj merged commit d75c08c into dev Sep 18, 2023
2 checks passed
@daileytj daileytj deleted the fix/4706-change-pw-dialog-props branch September 18, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering
Development

Successfully merging this pull request may close these issues.

3 participants