Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix emailSupportContent and phoneSupportContent prop #472

Merged

Conversation

ektaghag-eaton
Copy link
Contributor

Fixes 4700 .

Changes proposed in this Pull Request:

  • fix emailSupportContent, phoneSupportContent, onDismiss props are not working
  • Fix WorkflowCardInstriction and WorkflowCardBaseProps prop not working

Screenshots / Screen Recording (if applicable)

Screenshot 2023-09-12 at 4 32 25 PM

To Test:

<ContactSupportScreen icon={<AlarmAdd />} emailSupportTitle={'This is email support title prop'} emailSupportContent={ (email: string) => { returnSend here ${email}} } phoneSupportTitle={'123-456-6798'} phoneSupportContent={ (phone: string) => { returnCall here ${phone}`
}
}
contactEmail={
'[email protected]'
}
contactPhone='012-3404949-494'
dismissButtonLabel={
'Dismiss'
}
onDismiss={
() => {
console.log('Dismiss function called')
}
}
WorkflowCardBaseProps={{
loading: false,
backgroundImage: EatonLogo,
}}
WorkflowCardHeaderProps={{
avatar: ,
action: ,
title: 'This is a Contact Header',
}}
WorkflowCardInstructionProps={
{
instructions: 'This is a Contact Screen',
divider: false,
title: 'This is contact screen title'
}
}
WorkflowCardActionsProps={{
divider: false,
showPrevious: true,
canGoPrevious: true,
previousLabel: 'prev',
onPrevious: (): void => {
console.log('Previous button called');
},
showNext: true,
canGoNext: true,
nextLabel: 'next',
onNext: (): void => {
console.log('Next button called');
},
currentStep: 1,
totalSteps: 3,
fullWidthButton: true
}}
/>

`

Any specific feedback you are looking for?

@github-actions github-actions bot added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Sep 12, 2023
Copy link
Collaborator

@JeffGreiner-eaton JeffGreiner-eaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to be working now

@ektaghag-eaton ektaghag-eaton merged commit cbd9f4b into dev Sep 13, 2023
3 of 4 checks passed
@ektaghag-eaton ektaghag-eaton deleted the fix/BLUI-4700-missing-contact-support-screen-props branch September 13, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering
Development

Successfully merging this pull request may close these issues.

2 participants