Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/4710 pass code email invite registration #471

Merged
merged 3 commits into from
Sep 13, 2023
Merged

Feature/4710 pass code email invite registration #471

merged 3 commits into from
Sep 13, 2023

Conversation

surajeaton
Copy link
Collaborator

Fixes # BLUI-4710

Changes proposed in this Pull Request:

  • Updated invite registration route with code and email
  • Updated routing doc

Screenshots / Screen Recording (if applicable)

Screenshot 2023-09-12 at 2 30 37 PM

To Test:

  • cd login-workflow
  • yarn start:example
  • Click on Debug button
  • Click in Test Invite Register link
  • Check url should have code and email

Any specific feedback you are looking for?

@github-actions github-actions bot added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Sep 12, 2023
@github-actions
Copy link

github-actions bot commented Sep 12, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit 0688c27):

https://blui-react-login--pr471-feature-4710-pass-co-ej76pxb0.web.app

(expires Thu, 14 Sep 2023 15:27:41 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1e9064d2e35ed37fe01e053587ea5f209719a043

ektaghag-eaton
ektaghag-eaton previously approved these changes Sep 12, 2023
View reviewed changes
login-workflow/example/src/components/DebugComponent.tsx Outdated Show resolved Hide resolved
@ektaghag-eaton ektaghag-eaton dismissed their stale review September 12, 2023 12:08

By mistake approved

@surajeaton surajeaton merged commit 78b2302 into dev Sep 13, 2023
2 checks passed
@surajeaton surajeaton deleted the feature/4710-pass-code-email-invite-registration branch September 13, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeffGreiner-eaton JeffGreiner-eaton JeffGreiner-eaton approved these changes

@huayunh huayunh Awaiting requested review from huayunh

@joebochill joebochill Awaiting requested review from joebochill

@manojleaton manojleaton Awaiting requested review from manojleaton

@daileytj daileytj Awaiting requested review from daileytj

@ektaghag-eaton ektaghag-eaton Awaiting requested review from ektaghag-eaton ektaghag-eaton is a code owner

Assignees
No one assigned
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@surajeaton @JeffGreiner-eaton @ektaghag-eaton