Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update passwordValidator and passwordRequiredValidatorText prop #470

Merged
merged 3 commits into from
Sep 18, 2023

Conversation

ektaghag-eaton
Copy link
Contributor

@ektaghag-eaton ektaghag-eaton commented Sep 11, 2023

Fixes BLUI 4703

Changes proposed in this Pull Request:

  • Make passwordValidator props accessible from the LoginScreen component.
  • Remove passwordRequiredValidatorText from the LoginScreen component.

Screenshots / Screen Recording (if applicable)

To Test:

  • Add below code snippet below in
    passwordValidator={(password: string): boolean | string => { if (password?.length > 5) { return true; } return 'Password must be at least 6 characters'; }}

  • go to http://localhost:3000/login

  • enter a password less than 6 characters login button will be disabled

  • blur password input field will show an error message Password must be at least 6 characters

Any specific feedback you are looking for?

@github-actions github-actions bot added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Sep 11, 2023
@github-actions
Copy link

github-actions bot commented Sep 11, 2023

Visit the preview URL for this PR (updated for commit f83db23):

https://blui-react-login--pr470-fix-blui-4703-access-duxbk79w.web.app

(expires Mon, 18 Sep 2023 05:25:24 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1e9064d2e35ed37fe01e053587ea5f209719a043

@ektaghag-eaton
Copy link
Contributor Author

@surajeaton , please review.

@daileytj daileytj merged commit 40c45b6 into dev Sep 18, 2023
2 checks passed
@daileytj daileytj deleted the fix/BLUI-4703-access-login-props branch September 18, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering
Development

Successfully merging this pull request may close these issues.

3 participants