-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass WorkflowCard props to every screen component #469
Conversation
Visit the preview URL for this PR (updated for commit 41a3480): https://blui-react-login--pr469-fix-blui-4694-workfl-l1cp299e.web.app (expires Fri, 22 Sep 2023 10:24:31 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 1e9064d2e35ed37fe01e053587ea5f209719a043 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve the conflicts.
login-workflow/src/screens/AccountDetailsScreen/AccountDetailsScreenBase.tsx
Outdated
Show resolved
Hide resolved
login-workflow/src/screens/ContactScreen/ContactSupportScreen.tsx
Outdated
Show resolved
Hide resolved
…into fix/blui-4694-workflow-card-issue
Done please review |
login-workflow/src/screens/ExistingAccountSuccessScreen/ExistingAccountSuccessScreen.tsx
Outdated
Show resolved
Hide resolved
login-workflow/src/screens/RegistrationSuccessScreen/RegistrationSuccessScreen.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve the conflicts
…into fix/blui-4694-workflow-card-issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lint is failing.
@JeffGreiner-eaton and @surajeaton fixed PR comments. Please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Make sure to undo the changes did for testing before merging.
…into fix/blui-4694-workflow-card-issue
@ektaghag-eaton please update app router test code |
Looks fine to me. I might've opted to go with a single |
…into fix/blui-4694-workflow-card-issue
Fixes BLUI-4694 .
Changes proposed in this Pull Request:
Screenshots / Screen Recording (if applicable)
To Test:
Any specific feedback you are looking for?
-1. By default, making the
divider
value true so if the user wants to hide the divider needs to pass code like the below:<VerifyCodeScreen
WorkflowCardInstructionProps={{
instructions: 'Test Instruction',
divider: false,
}}
WorkflowCardActionsProps={{
divider: false,
}}
/>
WorkflowCardBaseProps
,WorkflowCardHeaderProps
,WorkflowCardInstructionProps
and WorkflowCardActionsPropsNote: For testing purpose, I have added code snippets for every component in AppRouter Please uncomment code while testing along with the default behaviour.