Update sx implementation on base screens to ensure we are using sx correctly #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manojleaton
requested review from
surajeaton,
daileytj and
JeffGreiner-eaton
as code owners
github-actions
bot
added
the
brightlayer-ui
|
Visit the preview URL for this PR (updated for commit b23dbc2): https://blui-react-login--pr468-4305-update-sx-in-l1oh9g5u.web.app (expires Wed, 13 Sep 2023 11:52:25 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 1e9064d2e35ed37fe01e053587ea5f209719a043 |
daileytj
reviewed
Sep 8, 2023
login-workflow/src/components/PasswordTextField/PasswordTextField.tsx
Outdated
Show resolved
Hide resolved
| position: 'relative', | ||
| borderRadius: { xs: 0, sm: '4px' }, | ||
| }, | ||
| ...(Array.isArray(sx) ? sx : [sx]), |
There was a problem hiding this comment.
Why is this being removed?
There was a problem hiding this comment.
As per the discussion with Joe in Office hours, we just need to merge the sx prop which is being passed with the parent component not with the children components.
| p: 0, | ||
| '& .MuiMobileStepper-dot': showStepperDots ? { my: 0, mx: 0.5 } : { display: 'none' }, | ||
| }, | ||
| ...(Array.isArray(sx) ? sx : [sx]), |
There was a problem hiding this comment.
Why is this being removed?
There was a problem hiding this comment.
same comment as above
daileytj
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #BLUI-4305 .
Changes proposed in this Pull Request:
To Test:
Any specific feedback you are looking for?