Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update firebase deployment on PR #940

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

JeffGreiner-eaton
Copy link
Collaborator

Fixes BLUI-6355.

Changes proposed in this Pull Request:

  • Update firebase deploy to use latest

Screenshots / Screen Recording (if applicable)

To Test:

Any specific feedback you are looking for?

@github-actions github-actions bot added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Dec 11, 2024
Copy link

github-actions bot commented Dec 11, 2024

Visit the preview URL for this PR (updated for commit 89397fb):

https://blui-react-docs--pr940-feature-blui-6355-fi-ohffsn4c.web.app

(expires Wed, 18 Dec 2024 17:01:44 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 34d39fa5aab0ea0cf95074e8e76f68829e7a8c65

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.96%. Comparing base (15aae8b) to head (89397fb).
Report is 6 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #940   +/-   ##
=======================================
  Coverage   80.96%   80.96%           
=======================================
  Files          47       47           
  Lines        1240     1240           
  Branches      156      156           
=======================================
  Hits         1004     1004           
  Misses        137      137           
  Partials       99       99           
Flag Coverage Δ
unittests 80.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shubham-eaton
Copy link
Contributor

@JeffGreiner-eaton keeping below code makes the build fail. Can we make changes as per typescript's suggestion to make it string.
onPointerEnterCapture?: React.PointerEventHandler | undefined;
onPointerLeaveCapture?: React.PointerEventHandler | undefined;

surajeaton
surajeaton previously approved these changes Dec 16, 2024
@surajeaton surajeaton dismissed their stale review December 16, 2024 08:28

PR comments

@JeffGreiner-eaton
Copy link
Collaborator Author

JeffGreiner-eaton commented Dec 16, 2024

@JeffGreiner-eaton keeping below code makes the build fail. Can we make changes as per typescript's suggestion to make it string. onPointerEnterCapture?: React.PointerEventHandler | undefined; onPointerLeaveCapture?: React.PointerEventHandler | undefined;

I see, we need to update react showcase for that. Guess we need to use this instead.

onPointerEnterCapture?: string | undefined;
onPointerLeaveCapture?: string | undefined;

We won't fix this in this PR, this PR is to update the deployment on PR for React Dev Docs. I will write issue up for react showcase.

This PR should be merged in part of updating the firebase deployment

@shubham-eaton
Copy link
Contributor

@JeffGreiner-eaton keeping below code makes the build fail. Can we make changes as per typescript's suggestion to make it string. onPointerEnterCapture?: React.PointerEventHandler | undefined; onPointerLeaveCapture?: React.PointerEventHandler | undefined;

I see, we need to update react showcase for that. Guess we need to use this instead.

onPointerEnterCapture?: string | undefined;
onPointerLeaveCapture?: string | undefined;

We won't fix this in this PR, this PR is to update the deployment on PR for React Dev Docs. I will write issue up for react showcase.

This PR should be merged in part of updating the firebase deployment

Will take up the fixes for showcase demo with another PR, approving this PR

@shubham-eaton shubham-eaton merged commit 8c02ed2 into dev Dec 17, 2024
16 of 17 checks passed
@shubham-eaton shubham-eaton deleted the feature/blui-6355-firebase-deploy branch December 17, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering
Development

Successfully merging this pull request may close these issues.

3 participants