-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update firebase deployment on PR #940
Conversation
Visit the preview URL for this PR (updated for commit 89397fb): https://blui-react-docs--pr940-feature-blui-6355-fi-ohffsn4c.web.app (expires Wed, 18 Dec 2024 17:01:44 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 34d39fa5aab0ea0cf95074e8e76f68829e7a8c65 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #940 +/- ##
=======================================
Coverage 80.96% 80.96%
=======================================
Files 47 47
Lines 1240 1240
Branches 156 156
=======================================
Hits 1004 1004
Misses 137 137
Partials 99 99
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@JeffGreiner-eaton keeping below code makes the build fail. Can we make changes as per typescript's suggestion to make it string. |
I see, we need to update react showcase for that. Guess we need to use this instead.
We won't fix this in this PR, this PR is to update the deployment on PR for React Dev Docs. I will write issue up for react showcase.
This PR should be merged in part of updating the firebase deployment |
Will take up the fixes for showcase demo with another PR, approving this PR |
Fixes BLUI-6355.
Changes proposed in this Pull Request:
Screenshots / Screen Recording (if applicable)
To Test:
Any specific feedback you are looking for?