Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update blui ci showcase build #936

Merged
merged 3 commits into from
Dec 6, 2024
Merged

Conversation

JeffGreiner-eaton
Copy link
Collaborator

@JeffGreiner-eaton JeffGreiner-eaton commented Dec 5, 2024

Fixes BLUI-6344.

Changes proposed in this Pull Request:

  • update tarball path install for showcase
  • pickup some prettier changes
  • the global DOM Attributes need updated in showcase (reason for fail here)

Screenshots / Screen Recording (if applicable)

To Test:

Any specific feedback you are looking for?

@github-actions github-actions bot added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Dec 5, 2024
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.96%. Comparing base (fd0ea3d) to head (e95238a).
Report is 4 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #936   +/-   ##
=======================================
  Coverage   80.96%   80.96%           
=======================================
  Files          47       47           
  Lines        1240     1240           
  Branches      156      156           
=======================================
  Hits         1004     1004           
  Misses        137      137           
  Partials       99       99           
Flag Coverage Δ
unittests 80.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 5, 2024

Visit the preview URL for this PR (updated for commit e95238a):

https://blui-react-docs--pr936-feature-blui-6344-ci-eppgra1x.web.app

(expires Sun, 08 Dec 2024 10:34:19 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 34d39fa5aab0ea0cf95074e8e76f68829e7a8c65

@shubham-eaton
Copy link
Contributor

Changes looks good to me, approved the PR.
The build seems to be in dark mode even though light mode was selected
Screenshot 2024-12-06 at 3 39 35 PM

@shubham-eaton
Copy link
Contributor

@JeffGreiner-eaton fixed the theme mode toggling issue in this PR

@surajeaton surajeaton merged commit 262d1a5 into dev Dec 6, 2024
16 of 17 checks passed
@surajeaton surajeaton deleted the feature/blui-6344-ci-showcase-build branch December 6, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering
Development

Successfully merging this pull request may close these issues.

3 participants