-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add husky pre-commit and checks #912
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #912 +/- ##
==========================================
- Coverage 83.76% 80.85% -2.92%
==========================================
Files 58 47 -11
Lines 1226 1238 +12
Branches 154 156 +2
==========================================
- Hits 1027 1001 -26
- Misses 100 136 +36
- Partials 99 101 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Visit the preview URL for this PR (updated for commit c9ac902): https://blui-react-docs--pr912-feature-blui-6038-hu-lbhwh6zn.web.app (expires Fri, 27 Sep 2024 17:26:06 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 34d39fa5aab0ea0cf95074e8e76f68829e7a8c65 |
Fixes BLUI-6038.
Changes proposed in this Pull Request:
yarn initialize && yarn install:dependencies && yarn prettier:check && yarn lint && cd components && yarn test --coverage
Screenshots / Screen Recording (if applicable)
husky-pre-commit.mov
To Test:
git clone https://github.com/etn-ccis/blui-react-component-library.git
git checkout feature/blui-6038-husky-pre-commit
yarn install:dependencies
a.) use the vs code source control panel to stage and commit.
(the husky pre-commit runs in the background and when complete your commit will compete)
OR
b.) use the terminal
git add . && git commit -m 'my commit'
(running in terminal will display what pre-commit runs)Next test
"lines": 90
OR
Any specific feedback you are looking for?