Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added MenuListProps prop to user menu #908

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

surajeaton
Copy link
Contributor

Fixes # BLUI-6029 #893

Changes proposed in this Pull Request:

  • Added MenuListProps prop to user menu

Screenshots / Screen Recording (if applicable)

Screenshot 2024-09-07 at 1 20 51 AM

To Test:

  • Pass MenuProps={{ MenuListProps: { dataTestId: 'user-menu-one' } }} to UserMenu component in showcase demo
  • yarn start
  • Inspect Usermenu to see data test id

Any specific feedback you are looking for?

@surajeaton surajeaton requested a review from huayunh as a code owner September 6, 2024 20:27
@github-actions github-actions bot added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Sep 6, 2024
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.76%. Comparing base (b41571d) to head (47e49e3).
Report is 3 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #908   +/-   ##
=======================================
  Coverage   83.76%   83.76%           
=======================================
  Files          58       58           
  Lines        1226     1226           
  Branches      154      154           
=======================================
  Hits         1027     1027           
  Misses        100      100           
  Partials       99       99           
Flag Coverage Δ
unittests 83.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Sep 6, 2024

Visit the preview URL for this PR (updated for commit 47e49e3):

https://blui-react-docs--pr908-bug-6029-893-fix-men-5accflgk.web.app

(expires Sun, 08 Sep 2024 20:31:58 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 34d39fa5aab0ea0cf95074e8e76f68829e7a8c65

@ektaghag-eaton ektaghag-eaton merged commit d71f80e into dev Sep 9, 2024
20 checks passed
@ektaghag-eaton ektaghag-eaton deleted the bug/6029-893-fix-menu-list-props-in-user-menu branch September 9, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering
Development

Successfully merging this pull request may close these issues.

2 participants