Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect prop type in Toolbar Menu #903

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

manojleaton
Copy link
Contributor

Fixes #BLUI-6032 .

Changes proposed in this Pull Request:

Screenshots / Screen Recording (if applicable)

To Test:

Any specific feedback you are looking for?

@github-actions github-actions bot added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Sep 4, 2024
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.76%. Comparing base (58c5ab8) to head (d9a1ae8).
Report is 4 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #903   +/-   ##
=======================================
  Coverage   83.76%   83.76%           
=======================================
  Files          58       58           
  Lines        1226     1226           
  Branches      154      154           
=======================================
  Hits         1027     1027           
  Misses        100      100           
  Partials       99       99           
Flag Coverage Δ
unittests 83.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Sep 4, 2024

Visit the preview URL for this PR (updated for commit d9a1ae8):

https://blui-react-docs--pr903-bug-6032-incorrect-p-obpbs9ks.web.app

(expires Sat, 07 Sep 2024 08:23:14 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 34d39fa5aab0ea0cf95074e8e76f68829e7a8c65

@manojleaton manojleaton merged commit 8d4816e into dev Sep 5, 2024
17 checks passed
@manojleaton manojleaton deleted the bug/6032-Incorrect-prop-type-in-Toolbar-Menu branch September 5, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering
Development

Successfully merging this pull request may close these issues.

2 participants