Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appbar out of sync check animating is finished #858

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

JeffGreiner-eaton
Copy link
Collaborator

@JeffGreiner-eaton JeffGreiner-eaton commented Feb 22, 2024

Fixes #736.

Changes proposed in this Pull Request:

  • add hook to check animating is finished

Screenshots / Screen Recording (if applicable)

To Test:

Any specific feedback you are looking for?

@github-actions github-actions bot added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Feb 22, 2024
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f47f62b) 84.03% compared to head (cd31838) 83.93%.

Files Patch % Lines
components/src/core/AppBar/AppBar.tsx 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #858      +/-   ##
==========================================
- Coverage   84.03%   83.93%   -0.10%     
==========================================
  Files          58       58              
  Lines        1234     1239       +5     
  Branches      158      159       +1     
==========================================
+ Hits         1037     1040       +3     
- Misses         98      100       +2     
  Partials       99       99              
Flag Coverage Δ
unittests 83.93% <60.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Visit the preview URL for this PR (updated for commit cd31838):

https://blui-react-docs--pr858-bug-blui-5306-sync-a-xoung6dm.web.app

(expires Sat, 24 Feb 2024 18:33:54 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 34d39fa5aab0ea0cf95074e8e76f68829e7a8c65

@JeffGreiner-eaton JeffGreiner-eaton marked this pull request as ready for review February 22, 2024 18:36
@JeffGreiner-eaton
Copy link
Collaborator Author

I'll need to add some additional testing to appbar

@surajeaton surajeaton merged commit 21fee0a into dev Feb 27, 2024
15 of 17 checks passed
@surajeaton surajeaton deleted the bug/blui-5306-sync-appbar branch February 27, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering
Development

Successfully merging this pull request may close these issues.

AppBar collapse/expand state can get out of sync
2 participants