Upgrade ESlint version 9 support flat config #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
brightlayer-ui
JeffGreiner-eaton
changed the title
joebochill
reviewed
Oct 24, 2024
Comment on lines
+114
to
+115
| "no-shadow": "off", | ||
| "@typescript-eslint/no-shadow": ["error"] |
There was a problem hiding this comment.
Did you run prettier? There's mismatched single/double quotes convention.
joebochill
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes BLUI-6228 & #96
Changes proposed in this Pull Request:
Updated ESlint to version 9 and updated remaining dependencies to latest
Removed deprecated no-var-requires rule in favor of no-require-imports rule.
Removed deprecated no-throw-literal rule.
Update tsx & ts configs to support client side flat configs for ESlint v9.
Update
naming-conventionrule.Update change log.
The version range of TypeScript currently supported is >=4.8. 4 <5.6.0
Node.js < v18.18, v19 are no longer supported
Screenshots / Screen Recording (if applicable)
To Test:
Any specific feedback you are looking for?