Feature/3144 drawer transition #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rail -> Temporary transition can be viewed here: https://github.com/brightlayer-ui/angular-showcase-demo/tree/feature/rail-demo |
|
I see some odd behavior in firefox and not chrome on this branch. NG-drawer-trans-firefox.mov |
|
I was able to reproduce this & am looking into it now. Good catch @jeffvg ! |
|
@jeffvg I've opened an issue for the Firefox bug here: https://github.com/brightlayer-ui/angular-component-library/issues/440 |
jeffvg
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #82
Changes proposed in this Pull Request:
This bug was happening because the drawer width was being recalculated on
variantchange.In the
drawer-layout.component.tsfile...When the variant is updated to
temporary, the width of the drawer is quickly recalculated to it's full, non-collapsed size. This is becauseisCollapsed()was returningfalseafter the variant was updated totemporary.I've added in an edge-case that listens for this change & if the drawer is in a collapsed state, avoids the recalculated width until the drawer is fully dismissed from the screen.
Screenshots:
To Test:
persistenttotemporaryvariant. Try this for when the drawer is opened & closed.This also should be checked for the
railvariant.