Don't publish tf if input frame == output frame #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, this will cause tf errors like this in subscribing nodes:
Error: TF_SELF_TRANSFORM: Ignoring transform from authority "/stereo_undistort" with frame_id and child_frame_id "boson_right_optical_frame" because they are the same
at line 221 in /tmp/binarydeb/ros-kinetic-tf2-0.5.20/src/buffer_core.cpp
|
Can one of the admins verify this patch? |
|
Could somebody merge this please? |
|
@tkazik : This is another small PR that should be quick to review. Could you have a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, this will cause tf errors like this in subscribing nodes: