Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs improvement #22

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

# 0.3.4 -- added new ethjs-format

1. Unhandled promise rejection fixed, and is no longer being swolloed.
1. Unhandled promise rejection fixed, and is no longer being swallowed.
2. ethjs-rpc bump to 0.1.9

# 0.2.6 -- added new ethjs-format
Expand Down
2 changes: 1 addition & 1 deletion docs/developer-guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ npm run lint

## Travis-ci and Coveralls Testing

Note, this will generate a `coveralls` report locally.
Note, that this will generate a `coveralls` report locally.

```
npm run test-travis
Expand Down
2 changes: 1 addition & 1 deletion docs/user-guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ Error handling is done through function callbacks or promised catches.

## Browser Builds

`ethjs` provides production distributions for all of its modules that are ready for use in the browser right away. Simply include either `dist/ethjs-query.js` or `dist/ethjs-query.min.js` directly into an HTML file to start using this module. Note, an `Eth` object is made available globally.
`ethjs` provides production distributions for all of its modules that are ready for use in the browser right away. Simply include either `dist/ethjs-query.js` or `dist/ethjs-query.min.js` directly into an HTML file to start using this module. Note, that an `Eth` object is made available globally.

```html
<script type="text/javascript" src="ethjs-query.min.js"></script>
Expand Down
2 changes: 1 addition & 1 deletion src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ function generateFnFor(rpcMethodName, methodObject) {
return promiseToCallback(promise)(callback);
}

// only return promise if no callback provided
//Only return promise if no callback is provided
return promise;

async function performCall() {
Expand Down