Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: experimental messaging from readme #1426

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KolbyML
Copy link
Member

@KolbyML KolbyML commented Sep 6, 2024

What was wrong?

  • the readme says unix only, but this is no longer true (we want it to work with windows and would gladly take issues now)
  • I think the experimental messaging is out dated now and counter productive. We expect people Trin is ready to use, but then the readme tells me to not use it, it is counter productive

How was it fixed?

Removing the 2 issues from the readme.

Programs change overtime for example sigp/discv5 and ethereum/go-ethereum change over time but don't have this kind of messaging in the readme.

If we verbally say we are ready for other's to take us seriously, I think messaging and this PR is the first step.

Same goes for window's support

@KolbyML KolbyML self-assigned this Sep 6, 2024
@KolbyML KolbyML changed the title chore: remove only unix + experimental messaging from readme chore: remove unix only + experimental messaging from readme Sep 6, 2024
@ogenev
Copy link
Member

ogenev commented Sep 6, 2024

I don't feel that removing the unix only note from the readme is the first step for fully supporting Windows. I think we need to first identify what are the current bottlenecks (if any) for fully supporting the platform.

For example, we can start with adding a build test for Windows in CircleCI (because cargo check doesn't catch all compilation errors).

@KolbyML
Copy link
Member Author

KolbyML commented Sep 6, 2024

For example, we can start with adding a build test for Windows in CircleCI (because cargo check doesn't catch all compilation errors).

Can you link a source maybe I have a misunderstanding how cargo check works?

@KolbyML
Copy link
Member Author

KolbyML commented Sep 6, 2024

For example, we can start with adding a build test for Windows in CircleCI (because cargo check doesn't catch all compilation errors).

Can you link a source maybe I have a misunderstanding how cargo check works?

To my understanding https://doc.rust-lang.org/cargo/commands/cargo-check.html cargo check does everything but code generation, which to my knowledge should check all compilations error's cargo build would. So it is like cargo build but faster and hence good for CI

@ogenev
Copy link
Member

ogenev commented Sep 6, 2024

Can you link a source maybe I have a misunderstanding how cargo check works?

https://rust-lang.github.io/rfcs/3477-cargo-check-lang-policy.html#decision

https://stackoverflow.com/a/69140084

@KolbyML
Copy link
Member Author

KolbyML commented Sep 6, 2024

Can you link a source maybe I have a misunderstanding how cargo check works?

https://rust-lang.github.io/rfcs/3477-cargo-check-lang-policy.html#decision

https://stackoverflow.com/a/69140084

Ah ok in that case maybe we should just stop using cargo check all together. Thank you for informing me I wasn't aware of that

@KolbyML KolbyML force-pushed the remove-certain-messaging branch from e5c423b to a39bbaa Compare January 11, 2025 17:41
@KolbyML KolbyML changed the title chore: remove unix only + experimental messaging from readme chore: experimental messaging from readme Jan 11, 2025
@KolbyML
Copy link
Member Author

KolbyML commented Jan 11, 2025

I removed the UNIX only part in this PR already, so the experimental part is the only part left #1452

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants