-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: experimental messaging from readme #1426
base: master
Are you sure you want to change the base?
Conversation
I don't feel that removing the unix only note from the readme is the first step for fully supporting Windows. I think we need to first identify what are the current bottlenecks (if any) for fully supporting the platform. For example, we can start with adding a build test for Windows in CircleCI (because cargo check doesn't catch all compilation errors). |
Can you link a source maybe I have a misunderstanding how cargo check works? |
To my understanding https://doc.rust-lang.org/cargo/commands/cargo-check.html cargo check does everything but code generation, which to my knowledge should check all compilations error's cargo build would. So it is like cargo build but faster and hence good for CI |
https://rust-lang.github.io/rfcs/3477-cargo-check-lang-policy.html#decision |
Ah ok in that case maybe we should just stop using cargo check all together. Thank you for informing me I wasn't aware of that |
85aaa5c
to
e5c423b
Compare
e5c423b
to
a39bbaa
Compare
I removed the UNIX only part in this PR already, so the experimental part is the only part left #1452 |
What was wrong?
How was it fixed?
Removing the 2 issues from the readme.
Programs change overtime for example sigp/discv5 and ethereum/go-ethereum change over time but don't have this kind of messaging in the readme.
If we verbally say we are ready for other's to take us seriously, I think messaging and this PR is the first step.
Same goes for window's support