Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make stop_process_timer return duration #1306

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

morph-dev
Copy link
Collaborator

What was wrong?

The StorageMetricsReporter doesn't return elapsed duration when stop_process_timer is called, which can be useful in some situations.

This is a followup from #1295.

How was it fixed?

Make stop_process_timer return elapsed duration and use it to simplify the logic for updating pruning strategy.

To-Do

@morph-dev morph-dev requested a review from carver May 22, 2024 05:56
@morph-dev morph-dev self-assigned this May 22, 2024
Copy link
Collaborator

@njgheorghita njgheorghita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@morph-dev morph-dev merged commit 306aace into ethereum:master Jul 1, 2024
8 checks passed
@morph-dev morph-dev deleted the storage_timer branch July 1, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants