fix normalizePath #3524
Merged
fix normalizePath #3524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
joeizang
approved these changes
Mar 14, 2023
| @@ -54,7 +54,7 @@ export class HardhatClient extends PluginClient { | |||
| const errMsg = '[Hardhat Compilation]: Cannot compile in read-only mode' | |||
| return reject(new Error(errMsg)) | |||
| } | |||
| const cmd = `npx hardhat compile --config ${configPath}` | |||
| const cmd = utils.normalizePath(`./node_modules/.bin/hardhat compile --config ${utils.normalizePath(configPath)}`) | |||
There was a problem hiding this comment.
this will only work if node is in the path that electron has when running standalone.
[Hardhat Compilation]: env: node: No such file or directory
bunsenstraat
requested changes
Mar 14, 2023
There was a problem hiding this comment.
this will only work if node is in the path that electron has when running standalone.
which it isn't by default, could be in brew, /usr/local/bin, anything, without the path of the user we won't know. On my system it says when I run this in a standalone remix desktop build
[Hardhat Compilation]: env: node: No such file or directory
we need to get the path from 1. the default shell if we can get it to run 2. input of the user.
bunsenstraat
approved these changes
Mar 15, 2023
yann300
force-pushed
the
fix_hardhat_call
branch
from
a0aeef0 to
15ca5b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.