More cleanup of validity language for proofs and formatting #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdeme
reviewed
Jan 13, 2024
state-network.md
Outdated
|
|
||
| ###### B: No Extraneous Nodes | ||
|
|
||
| A witness MAY NOT contain any nodes that are not part of the set needed to for proving. |
There was a problem hiding this comment.
From the context within this PR I'd say that the MAY NOT should be rather a SHOULD NOT or MUST NOT?
state-network.md
Outdated
|
|
||
| ##### C: No Redundant Nodes | ||
|
|
||
| A witness MAY NOT contain any nodes that can be computed from other nodes in |
There was a problem hiding this comment.
switching both to MUST NOT
pipermerriam
merged commit 8b4b902
into
ethereum:new-statenetwork-boogie
2 checks passed
pipermerriam
added a commit
that referenced
this pull request
Jan 29, 2024
* delete removed sections * remove old data types * Allow Offer and Request data types to differ * define nibble types * Add Function definitions * Define `Account Trie Node` data type * Define `Contract Trie Node` data type * Add section to define `Contract Code` data type * commit todos * WIP: STATE SPECS V2 * some disperate changes * some language updates * Add language describing the path aware content-id scheme (#250) * Remove path-aware content-id generation (#252) * Add definition of recursive gossip (#254) * initial definition of recursive gossip * Update state-network.md Co-authored-by: Kim De Mey <[email protected]> * Update state-network.md Co-authored-by: Kim De Mey <[email protected]> * Update state-network.md Co-authored-by: Kim De Mey <[email protected]> * Update state-network.md Co-authored-by: Kim De Mey <[email protected]> * Update state-network.md Co-authored-by: Kim De Mey <[email protected]> * Update state-network.md Co-authored-by: Kim De Mey <[email protected]> --------- Co-authored-by: Kim De Mey <[email protected]> * Better define serialization formats (#255) * Better define serialization formats * more updates to witness formats * Additional validity requirements and spec fixes for state witnesses (#257) * Additional validity requirements and spec fixes for state witnesses * add TODO * More cleanup of validity language for proofs and formatting (#260) * More cleanup of validity language for proofs and formatting * use MUST NOT instead of MAY NOT * more language and formatting tweaks for state network specification (#261) * More specificity around bridge node gossip priority ordering for content (#263) * offer/retrieval union content types splitted into separate types/subsections (#262) * language clarification for the use of different data types * remove content_id definition from types + lang fix for content_id * clarify nibbles packing (align it with MPT) and provide examples (#266) * update the gossip spec and clarify what proof actually contains (#267) * update the gossip spec and clarify what proof actually contains * clarify that recursive gossip doesn't happen for bytecode --------- Co-authored-by: Piper Merriam <[email protected]> Co-authored-by: Kim De Mey <[email protected]> Co-authored-by: Daniel Sobol <[email protected]> Co-authored-by: Milos Stankovic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More tweaks and adjustments to state nework spec.