p2p: support configuring NAT in TOML file #31041

fjl · 2025-01-17T15:40:00Z

This is an alternative for #27407 with a solution based on gencodec. With the PR, one can now configure like this:

# config.toml
[Node.P2P]
NAT = "extip:33.33.33.33"

$ geth --config config.toml
...
INFO [01-17|16:37:31.436] Started P2P networking      self=enode://[email protected]:30303

p2p/config.go

go.mod

fjl requested a review from zsfelfoldi as a code owner January 17, 2025 15:40

This was referenced Jan 17, 2025

p2p: Make NAT-spec toml-friendly #27407

Closed

Geth failed to start with NAT in config.toml #27394

Closed

georgehao reviewed Jan 17, 2025

View reviewed changes

rjl493456442 reviewed Jan 20, 2025

View reviewed changes

go.mod Outdated Show resolved Hide resolved

rjl493456442 previously approved these changes Jan 21, 2025

View reviewed changes

fjl added 5 commits January 21, 2025 22:44

go.mod: upgrade gencodec

6909dd9

p2p: support configuring NAT in TOML

50e0380

go.sum: go mod tidy

663de35

p2p/nat: add MarshalText to instances

0fa7608

go.mod: fixup version line

0217ec1

fjl dismissed rjl493456442’s stale review via 0217ec1 January 21, 2025 21:50

fjl force-pushed the p2p-nat-toml branch from c5b6d04 to 0217ec1 Compare January 21, 2025 21:50

fjl merged commit 218b697 into ethereum:master Jan 22, 2025
3 checks passed

fjl modified the milestones: 1.14.13, 1.15.0 Jan 22, 2025

Provide feedback