library/math: Added standard math functions #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added standard math library, including: * Two dimensional euclidean distance * Square root * Linear interpolation
| } | ||
|
|
||
| /// @dev Returns the linear interpolation between a and b | ||
| function lerp(uint x_a, uint y_a, uint x_b, uint y_b, uint delta) returns (uint x, uint y) { |
There was a problem hiding this comment.
Not sure what you mean with why?
Are you asking why I needed it here or are you asking about the reasoning behind adding it to a math lib?
There was a problem hiding this comment.
I think he's asking why the function is called lerp. FYI lerp is the canonical shortened name (I believe) for the Linear Interpolation function.
There was a problem hiding this comment.
Yes I see now. I should have paid closer attention to the implementation when asked to rename the functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added standard math library, including: