Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kontrol proof prove_relayMessage_paused #9156

Merged
merged 14 commits into from
Jan 24, 2024

Conversation

JuanCoRo
Copy link
Contributor

Description

Building on #9092, this PR does the following:

  • Adds a new proof, prove_relayMessage_paused
  • Bumps Kontrol version from 0.1.121 to 0.1.127

Tests

In tests/kontrol/proofs/L1CrossDomainMessenger.k.sol, the symbolic property test prove_relayMessage_paused is added

@JuanCoRo JuanCoRo marked this pull request as ready for review January 23, 2024 23:42
@JuanCoRo JuanCoRo requested a review from a team as a code owner January 23, 2024 23:42
@JuanCoRo JuanCoRo requested a review from Inphi January 23, 2024 23:42
Copy link
Contributor

coderabbitai bot commented Jan 23, 2024

Walkthrough

Walkthrough

The updates focus on enhancing the testing and deployment mechanisms for the L1CrossDomainMessenger contract within the Optimism ecosystem. The changes introduce virtual test functions for extension, a new contract for symbolic property testing, and interfaces for cross-domain messaging functionality. Additionally, the deployment process for the messenger contract has been expanded, and the testing infrastructure has been improved to include more descriptive references and to facilitate the testing of the new functionality.

Changes

File(s) Change Summary
.../L1/L1CrossDomainMessenger.t.sol Marked test functions as virtual, added @notice comments for overriding, and updated contract names.
.../README.md, .../deployment/KontrolDeployment.sol Updated file descriptions, added new functions for cross-domain messenger deployment, and revised folder content.
.../proofs/L1CrossDomainMessenger.k.sol, .../proofs/interfaces/KontrolInterfaces.sol Introduced new contract for proving message pausing and a new interface for the messenger.
.../proofs/utils/DeploymentSummary.sol Modified internal constants, added address declarations, and updated contract logic for address storage.
.../scripts/run-kontrol.sh Updated script instructions, modified variables for the kontrol installation and execution process.
.../reverse_key_values.py Altered functionality to convert keys to lowercase before reversing in the reverse_json function.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Contributor

@mds1 mds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All small cmments. CI runtime still looking good too!
image

@mds1 mds1 added this pull request to the merge queue Jan 24, 2024
Merged via the queue into ethereum-optimism:develop with commit 34592a1 Jan 24, 2024
64 checks passed
@mds1 mds1 deleted the milestone-2 branch January 24, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants