Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fast summarization for Kontrol proofs #9092

Merged
Merged
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
ace7885
KontrolDeployment: move to `deployment` folder
JuanCoRo Jan 18, 2024
847d4a9
Add `DeploymentSummary.t.sol`
JuanCoRo Jan 18, 2024
5ce1e7d
`DeploymentSummary`: `vm` visivility from `internal` to `private`
JuanCoRo Jan 18, 2024
f6e0c9a
KontrolUtils: `vm` visivility form `private` to `internal`
JuanCoRo Jan 18, 2024
0f8ab05
Add fast summarization; run `finalizeWithdrawalTransaction` proof
JuanCoRo Jan 18, 2024
3f5d419
Delete dummy proofs
JuanCoRo Jan 18, 2024
58982f5
README.md: Reflect `deployment` folder & deletion of `proofs/tests`
JuanCoRo Jan 18, 2024
dad86e3
`run-kontrol.sh`: fix path for `Kontrol-Deploy.json`
JuanCoRo Jan 19, 2024
0fb9cc9
`OptimismPortal_Test`: set `virtual` functions to override in Kontrol…
JuanCoRo Jan 19, 2024
8b7710d
`DeploymentSummary_Test`: Tidy up & remove innecessary code
JuanCoRo Jan 19, 2024
dc0178e
`versions.json`: bump Kontrol from `0.1.117` to `0.1.121`
JuanCoRo Jan 19, 2024
f887763
Update `Kontrol-Deploy.json`
JuanCoRo Jan 19, 2024
27aaba4
`run-kontrol.sh`: remove `bmc` proving mode
JuanCoRo Jan 19, 2024
643e22e
`OptimismPortalKontrol`: inline `setUp` function
JuanCoRo Jan 19, 2024
ca01f4b
`OptimismPortal_Test`: fix typo in comments
JuanCoRo Jan 19, 2024
f4dcdbf
Prettify `snapshots/state-diff/Kontrol-Deploy.json`
JuanCoRo Jan 22, 2024
a78dbca
`run-kontrol.sh`: add logs to `test/kontrol/logs` instead of root
JuanCoRo Jan 22, 2024
a903972
Merge remote-tracking branch 'origin/develop' into kontrol-fast-summa…
JuanCoRo Jan 22, 2024
558d860
Update Kontrol deployment summary
JuanCoRo Jan 22, 2024
478b5d4
`DeploymentSummary_Test`: Update `test_constructor_suceeds`; add `tes…
JuanCoRo Jan 22, 2024
7f1c7aa
`DeploymentSummary_Test`: fix typos
JuanCoRo Jan 23, 2024
71381d4
`DeploymentSummary_Test`: remove `vm.skip(true)`
JuanCoRo Jan 23, 2024
627e387
`OptimismPortalKontrol`: simplify test logic
JuanCoRo Jan 23, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -50,16 +50,10 @@ contract OptimismPortalKontrol is DeploymentSummary, KontrolUtils {
Types.OutputRootProof memory _outputRootProof =
Types.OutputRootProof(_outputRootProof0, _outputRootProof1, _outputRootProof2, _outputRootProof3);

// After deployment, Optimism portal is enabled
require(optimismPortal.paused() == false, "Portal should not be paused");

// Pause Optimism Portal
vm.prank(optimismPortal.GUARDIAN());
superchainConfig.pause("identifier");

// Portal is now paused
require(optimismPortal.paused(), "Portal should be paused");

mds1 marked this conversation as resolved.
Show resolved Hide resolved
// No one can call proveWithdrawalTransaction
vm.expectRevert("OptimismPortal: paused");
optimismPortal.proveWithdrawalTransaction(_tx, _l2OutputIndex, _outputRootProof, _withdrawalProof);
Expand All @@ -83,16 +77,10 @@ contract OptimismPortalKontrol is DeploymentSummary, KontrolUtils {
Types.WithdrawalTransaction memory _tx =
Types.WithdrawalTransaction(_nonce, _sender, _target, _value, _gasLimit, _data);

// After deployment, Optimism portal is enabled
require(optimismPortal.paused() == false, "Portal should not be paused");

// Pause Optimism Portal
vm.prank(optimismPortal.GUARDIAN());
superchainConfig.pause("identifier");

// Portal is now paused
require(optimismPortal.paused(), "Portal should be paused");

vm.expectRevert("OptimismPortal: paused");
optimismPortal.finalizeWithdrawalTransaction(_tx);
}
Expand Down