Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ct): Proofs - Basic DelayedWETH Capability Expansion #12728

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

wildmolasses
Copy link

@wildmolasses wildmolasses commented Oct 29, 2024

Description

Draft PR expanding DelayedWETH, per #12174

Note: This draft PR is preliminary, created in order to facilitate spec formulation. See spec PR here: ethereum-optimism/specs#453

Tests

  • added a test asserting that withdrawals can't happen when the local withdrawalsPaused flag is true
  • modified test_hold_succeeds, revising assertions according to new balance transfer functionality
  • added setWithdrawalsPaused tests

Additional context

Questions:

  • should I refactor more of the DelayedWETH tests to fuzz?
  • As DelayedWETH is upgradeable, should storage layout changes be triple-checked?

Metadata

@wildmolasses wildmolasses changed the title DelayedWETH expansion feat(ct): DelayedWETH expansion Oct 29, 2024
@wildmolasses wildmolasses changed the title feat(ct): DelayedWETH expansion feat(ct): Proofs - Basic DelayedWETH Capability Expansion Oct 29, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.91%. Comparing base (b02dba0) to head (b6a32a4).
Report is 244 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12728      +/-   ##
===========================================
- Coverage    64.10%   63.91%   -0.19%     
===========================================
  Files           52       52              
  Lines         4312     4312              
===========================================
- Hits          2764     2756       -8     
- Misses        1374     1383       +9     
+ Partials       174      173       -1     
Flag Coverage Δ
cannon-go-tests 63.91% <ø> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@wildmolasses wildmolasses force-pushed the 10-24-delayedweth_expansion branch from b6a32a4 to 3cbe0a1 Compare November 8, 2024 08:30
@wildmolasses wildmolasses force-pushed the 10-24-delayedweth_expansion branch from 3cbe0a1 to 03d11bb Compare November 8, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Proofs: Basic DelayedWETH Capability Expansion
1 participant