Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: Add Ecotone override flag #233

Merged
merged 1 commit into from
Jan 31, 2024
Merged

all: Add Ecotone override flag #233

merged 1 commit into from
Jan 31, 2024

Conversation

sebastianst
Copy link
Member

Description

We already had an Ecotone override flag, but it wasn't used.

Tests

Zach will test it in an internal devnet.

@sebastianst sebastianst self-assigned this Jan 31, 2024
trianglesphere
trianglesphere approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@trianglesphere trianglesphere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. This can be tested locally as well by using an empty datadir

@sebastianst sebastianst mentioned this pull request Jan 31, 2024
Merged
@sebastianst sebastianst enabled auto-merge January 31, 2024 22:06
@sebastianst sebastianst merged commit ea3c304 into optimism Jan 31, 2024
8 of 9 checks passed
@sebastianst sebastianst deleted the seb/ecotone-override branch January 31, 2024 22:08
@sebastianst sebastianst mentioned this pull request Apr 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trianglesphere trianglesphere trianglesphere approved these changes

Assignees

@sebastianst sebastianst

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebastianst @trianglesphere