beacon: Fix OP Legacy block hash checks #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trianglesphere
force-pushed
the
jg/fix_batch_verify_headers
branch
from
ea63a6b to
5fa45a6
Compare
When verifying a batch of headers, verify the parent inside the section of headers because they don't exist in the DB yet.
trianglesphere
force-pushed
the
jg/fix_batch_verify_headers
branch
from
5fa45a6 to
5ef4144
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the OP Legacy Consensus engine
VerifyHeadersfunction. WhenVerifyHeadersis called, only the first block is stored in the database & the reset are passed in as a slice. We previously calledVerifyHeaderfromVerifyHeaderswhich would expect that the block's parent was in the database. This modifiesVerifyHeadersto check that the first block is in the database & then checks the blocks one by one through the slice.Tests
I have tested this on op-goerli & op-mainnet.