-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snap Sync: consensus: handle legacy pre-bedrock header verification #182
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR is looking good. It needs a some lints to be fixed, but I'd like to get this in
5a9ad64
to
07b934f
Compare
07b934f
to
fb9c707
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should run a test in our snap sync infra before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I've also successfully used this code to snap sync op-goerli.
VerifyHeaders will be dealt with in a follow-up.
2713f2d
to
3080d04
Compare
Rebased on latest Fixed the unit-test, but had to jump through some hoops to make it work:
Solution:
Related fixes:
cc @trianglesphere, I think this unblocks this PR. PTAL |
Description
Handle legacy pre-bedrock block-headers in consensus validation, to support snap-syncing without prior data-dir.
Very experimental. See optimism monorepo PR for context.