Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Improvements: Grammar, Structure, and Readability Fixes #1057

Merged
merged 4 commits into from
Nov 4, 2024

Conversation

zoomyzo
Copy link
Contributor

@zoomyzo zoomyzo commented Nov 1, 2024

Description

Made comprehensive improvements to the documentation. The following corrections and enhancements were made to ensure clarity, accuracy, and readability:

Changes Made

• Fixed typos and grammatical errors to improve overall text quality.
• Inserted missing prepositions to enhance sentence flow.
• Removed duplicate words that appeared consecutively, reducing redundancy.
• Corrected spacing issues, splitting words where they were incorrectly merged.
• Eliminated unnecessary punctuation (e.g., periods where they were not needed).
• Enhanced readability by refining sentence structure and ensuring consistent style.

Tests

Since this PR only affects documentation, no code testing was required. All changes were thoroughly reviewed for accuracy and adherence to style guidelines.

Additional context

These changes were made to provide clear, professional, and user-friendly documentation, minimizing potential misunderstandings.

Metadata

@zoomyzo zoomyzo requested a review from a team as a code owner November 1, 2024 00:28
Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for docs-optimism ready!

Name Link
🔨 Latest commit 479804c
🔍 Latest deploy log https://app.netlify.com/sites/docs-optimism/deploys/6728c6242dfa390008f88183
😎 Deploy Preview https://deploy-preview-1057--docs-optimism.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Nov 1, 2024

Caution

Review failed

The head commit changed during the review from 69ee5d3 to 479804c.

Walkthrough

The pull request includes multiple modifications across several documentation files related to the OP Chain ecosystem. Changes primarily focus on enhancing clarity, correcting minor errors, and improving the overall structure of the documents. Specific updates involve hyperlink formatting, grammatical corrections, and detailed explanations of operational components, such as the op-conductor and op-deployer. The adjustments aim to maintain instructional quality while ensuring users have accurate and up-to-date information.

Changes

File Path Change Summary
pages/builders/chain-operators/self-hosted.mdx Removed a period from a hyperlink reference in the smart contracts section.
pages/builders/chain-operators/tools/op-conductor.mdx Refined introduction, clarified assumptions, detailed guarantees, expanded design section, and improved setup instructions. Minor grammatical corrections made.
pages/builders/chain-operators/tools/op-deployer.mdx Corrected "fee receipiant" to "fee recipient" in configuration example.
pages/builders/chain-operators/tutorials/adding-precompiles.mdx Updated introduction to clarify OP Stack Hacks, detailed steps for creating a new precompile, and clarified precompile interface.
pages/builders/node-operators/management/metrics.mdx Updated metric names and descriptions for clarity.
pages/builders/node-operators/tutorials/mainnet.mdx Clarified hardware requirements, updated SSD capacity requirements, and improved instructions for verifying downloaded files.
pages/builders/tools/monitor/regenesis-history.mdx Corrected "uses" to "users" in the discussion of lost data directories.

Possibly related PRs

  • 3 new node pages #679: This PR involves updating hyperlinks in documentation related to node configuration, which is relevant to the changes made in the main PR regarding hyperlink formatting in the self-hosted chain guide.
  • small fixes to op-conductor page #990: This PR enhances the op-conductor documentation, which is related to the main PR's focus on improving clarity and accuracy in documentation, particularly in the context of operational practices.
  • Op deployer updates #1020: This PR updates the op-deployer documentation, which is relevant as it also focuses on enhancing clarity and detail regarding deployment processes, similar to the changes made in the main PR.
  • adding op-deployer callouts #1016: This PR adds callouts to the op-deployer documentation, which aligns with the main PR's emphasis on improving user guidance and clarity in documentation.
  • tutorials: make geth before using geth init #1042: This PR introduces a new section in the tutorial for creating an L2 rollup, emphasizing the importance of building the op-geth binary first, which relates to the instructional improvements seen in the main PR.

Suggested labels

documentation

Suggested reviewers

  • sbvegan

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (7)
pages/builders/chain-operators/tutorials/adding-precompiles.mdx (3)

Line range hint 8-13: Improve the warning callout style.

Consider these refinements to align with the documentation guidelines:

  1. Replace "not" with "not" as italics shouldn't be used for emphasis
  2. Rephrase to avoid second-person pronouns:
    • "You will not be able to receive" → "Significant developer support is not available"
    • "be prepared to get your hands dirty" → "Implementation requires independent problem-solving"

Line range hint 15-17: Revise the introduction for technical documentation style.

  1. Replace second-person pronouns:
    • "you'll make" → "this tutorial demonstrates how to make"
  2. Capitalize technical terms:
    • "EVM" is correctly capitalized
    • Consider capitalizing "precompile" when referring to the specific component

91-91: Improve technical explanation style.

Replace the personal pronoun "we" with more formal language:

  • "we return" → "the function returns"
pages/builders/node-operators/management/metrics.mdx (1)

Line range hint 1-71: Additional documentation improvements needed.

While reviewing the entire document, I noticed several areas that could be improved according to the documentation guidelines:

  1. Title case usage in table headers needs adjustment
  2. Some sentences use personal pronouns that should be replaced with proper nouns

Here are the suggested improvements:

- | METRIC                                                     | DESCRIPTION                                                                                      | LABELS       | TYPE      |
+ | Metric                                                     | Description                                                                                      | Labels       | Type      |

- To monitor the health of your node, you should monitor the following metrics:
+ To monitor the health of the node, monitor the following metrics:

- Without peers, the `op-node` cannot sync unsafe blocks and your node will lag behind the sequencer
+ Without peers, the `op-node` cannot sync unsafe blocks and the node will lag behind the sequencer
pages/builders/node-operators/tutorials/mainnet.mdx (2)

276-277: Improve sentence clarity and conciseness

Consider revising the text for better readability:

-Snapshots are available for multiple dates and snapshots get larger as they get closer to the current date.
+Snapshots are available for multiple dates, with more recent snapshots being larger in size.

Line range hint 296-301: Enhance verification instructions clarity

Consider these improvements:

-You should see the following output:
+Expected output for this specific snapshot:

 ```bash
 ec4baf47e309a14ffbd586dc85376833de640c0f2a8d7355cb8a9e64c38bfcd1  mainnet-bedrock.tar.zst

</blockquote></details>
<details>
<summary>pages/builders/chain-operators/tools/op-conductor.mdx (1)</summary><blockquote>

`156-156`: **Improve formality in configuration note**

Replace the informal contraction with more formal language and add clarity about the incompatibility.

```diff
-      OP_NODE_RPC_ADMIN_STATE: "" # this flag can't be used with conductor
+      OP_NODE_RPC_ADMIN_STATE: "" # this flag cannot be used with conductor due to state management conflicts
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between d52a005 and 2f00d33.

📒 Files selected for processing (7)
  • pages/builders/chain-operators/self-hosted.mdx (1 hunks)
  • pages/builders/chain-operators/tools/op-conductor.mdx (2 hunks)
  • pages/builders/chain-operators/tools/op-deployer.mdx (1 hunks)
  • pages/builders/chain-operators/tutorials/adding-precompiles.mdx (1 hunks)
  • pages/builders/node-operators/management/metrics.mdx (1 hunks)
  • pages/builders/node-operators/tutorials/mainnet.mdx (2 hunks)
  • pages/builders/tools/monitor/regenesis-history.mdx (1 hunks)
✅ Files skipped from review due to trivial changes (2)
  • pages/builders/chain-operators/self-hosted.mdx
  • pages/builders/chain-operators/tools/op-deployer.mdx
🧰 Additional context used
📓 Path-based instructions (5)
pages/builders/chain-operators/tools/op-conductor.mdx (1)

Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • For H1, H2, and H3 headers:
    1. Use sentence case, capitalizing only the first word.
    2. Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
    3. Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
  • Flag any headers that seem to inconsistently apply these rules for manual review.
  • When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
    "
pages/builders/chain-operators/tutorials/adding-precompiles.mdx (1)

Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • For H1, H2, and H3 headers:
    1. Use sentence case, capitalizing only the first word.
    2. Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
    3. Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
  • Flag any headers that seem to inconsistently apply these rules for manual review.
  • When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
    "
pages/builders/node-operators/management/metrics.mdx (1)

Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • For H1, H2, and H3 headers:
    1. Use sentence case, capitalizing only the first word.
    2. Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
    3. Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
  • Flag any headers that seem to inconsistently apply these rules for manual review.
  • When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
    "
pages/builders/node-operators/tutorials/mainnet.mdx (1)

Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • For H1, H2, and H3 headers:
    1. Use sentence case, capitalizing only the first word.
    2. Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
    3. Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
  • Flag any headers that seem to inconsistently apply these rules for manual review.
  • When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
    "
pages/builders/tools/monitor/regenesis-history.mdx (1)

Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • For H1, H2, and H3 headers:
    1. Use sentence case, capitalizing only the first word.
    2. Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
    3. Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
  • Flag any headers that seem to inconsistently apply these rules for manual review.
  • When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
    "
🪛 LanguageTool
pages/builders/tools/monitor/regenesis-history.mdx

[uncategorized] ~66-~66: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...ed some of our community and their users and we're sorry for the frustrations. In an...

(COMMA_COMPOUND_SENTENCE)


[style] ~66-~66: “Sorry” is a very overused expression. Consider replacing it with a more formal alternative.
Context: ...me of our community and their users and we're sorry for the frustrations. In an effort to preve...

(APOLOGIZE)


[style] ~66-~66: Consider a shorter alternative to avoid wordiness.
Context: ...s and we're sorry for the frustrations. In an effort to prevent similar situations from happeni...

(IN_ORDER_TO_PREMIUM)

🔇 Additional comments (2)
pages/builders/node-operators/management/metrics.mdx (1)

36-36: Description improvements look good.

The removal of redundant "cache" word from the metric descriptions improves clarity and eliminates repetition.

Also applies to: 39-39

pages/builders/chain-operators/tools/op-conductor.mdx (1)

195-195: LGTM: Header follows sentence case guidelines

The header "Transfer leadership" correctly follows the sentence case guidelines for documentation headers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants