Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ~/ operator, most of uri getters, trim and String.fromCharCode to string, MapEntry wrapper and potential base64 wrapper #141

Merged
merged 5 commits into from
Nov 8, 2023

Conversation

Noobware1
Copy link
Contributor

@ethanblake4 could you please see the implemention for the ~/ operator cause it could be wrong the test case works so i think it's correct.

also i was trying to add removeWhere method on List but i wouldn't work if i do it like this saying bool is not subtype of $Value in typecast or something

final list = [1,2,3,4,5];
list.removeWhere((e) => e == 5);

but it would work if i do it like this

final list = [1,2,3,4,5];
bool remove(int e) {
return e == 5;
}

list.removeWhere((e) {
return remove(e);
});

also thanks for the guidance :)

@Noobware1 Noobware1 marked this pull request as draft November 4, 2023 17:05
@Noobware1 Noobware1 marked this pull request as ready for review November 4, 2023 17:10
@Noobware1
Copy link
Contributor Author

Sorry for the dumb error T-T

@Noobware1 Noobware1 changed the title Added ~/ operator, most of uri getters, added trim and String.fromCharCode to string, added a potential base64 wrapper Added ~/ operator, most of uri getters, added trim and String.fromCharCode to string, added MapEntry wrapper, added a potential base64 wrapper Nov 4, 2023
@Noobware1 Noobware1 changed the title Added ~/ operator, most of uri getters, added trim and String.fromCharCode to string, added MapEntry wrapper, added a potential base64 wrapper Added ~/ operator, most of uri getters, trim and String.fromCharCode to string, MapEntry wrapper and potential base64 wrapper Nov 4, 2023
Copy link
Owner

@ethanblake4 ethanblake4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! You should either uncomment or remove the Base64 stuff though depending on if it works.

@Noobware1 Noobware1 marked this pull request as draft November 7, 2023 04:39
@Noobware1
Copy link
Contributor Author

removed the base64 since it doesn't seem to work neither encode nor decode

@Noobware1 Noobware1 marked this pull request as ready for review November 7, 2023 04:44
@Noobware1 Noobware1 requested a review from ethanblake4 November 7, 2023 04:48
@ethanblake4 ethanblake4 merged commit 2634531 into ethanblake4:master Nov 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants