Skip to content

Commit

Permalink
generalize typing to avoid circular dependency
Browse files Browse the repository at this point in the history
  • Loading branch information
ethan-cartwright committed Dec 28, 2023
1 parent 7d2b3e7 commit 763789a
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
from datetime import datetime, timezone
from typing import (
TYPE_CHECKING,
Any,
Callable,
Dict,
Iterable,
Expand All @@ -19,7 +20,6 @@
from datahub.emitter.mcp import MetadataChangeProposalWrapper
from datahub.emitter.mcp_builder import entity_supports_aspect
from datahub.ingestion.api.workunit import MetadataWorkUnit
from datahub.ingestion.source.sql.sql_generic import BaseTable
from datahub.metadata.com.linkedin.pegasus2avro.common import TimeStamp
from datahub.metadata.schema_classes import (
BrowsePathEntryClass,
Expand Down Expand Up @@ -65,7 +65,7 @@ def auto_workunit(
def create_dataset_props_patch_builder(
datahub_dataset_name: str,
dataset_urn: str,
table: BaseTable,
table: Any, # TODO: refactor to avoid circular import while type-hinting with BaseTable
custom_properties: Optional[Dict[str, str]] = None,
) -> DatasetPatchBuilder:
"""Creates a patch builder with a table's or view's attributes and dataset properties"""
Expand Down

0 comments on commit 763789a

Please sign in to comment.