Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade goal_runner to work with z3 version 4.8.7 #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maciej-bendkowski
Copy link

The current pull request upgrades the goal_runner to support z3 version 4.8.7. Essentially, it uses z3's new API to parse SMT files, cf. Z3Prover/z3#2798. In addition, it proposes two lesser changes:

  • it uses the lowercase name of the fasttext library,
  • it adds #!/bin/sh to the run_test.sh script.

Please let me know if there's anything else I should be upgrading.

@ghost
Copy link

ghost commented Sep 28, 2020

DeepCode's analysis on #1608cf found:

  • ⚠️ 2 warnings 👇

Top issues

Description Example fixes
The result of fopen, which may return null flows to the first argument of fprintf. This could result in undefined behavior. Consider adding a check for nullness. Occurrences: 🔧 Example fixes
Missing close for tempfile.NamedTemporaryFile, add close or use a with block. Occurrences: 🔧 Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@deepcodeappdev
Copy link

DeepCode's analysis on #1608cf found:

  • ⚠️ 2 warnings 👇

Top issues

Description Example fixes
The result of fopen, which may return null flows to the first argument of fprintf. This could result in undefined behavior. Consider adding a check for nullness. Occurrences: 🔧 Example fixes
Missing close for tempfile.NamedTemporaryFile, add close or use a with block. Occurrences: 🔧 Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant