Make register categories not translatable #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually wait, this isn't sufficient. There's some problem with rFLAGS, it seems to be |
|
No worries, I won't merge until you say so 👍🏻 |
Categories are not user-visible, only used as ids for searching, so translation is an unnecessary complication that can break things. And the names of registers were never supposed to be translatable. Fixes eteran#868
The register view relies on these strings to keep the right geometry, and sometimes even for functionality, so they shouldn't be translated.
|
OK, now it seems to work. |
eteran
approved these changes
Jul 25, 2024
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are not user-visible, only used as ids for searching, so translation is an unnecessary complication that can break things.
Fixes #868