initializing QPointer isn't necessary (and throws off clang-tidy for …

…some reason) adding [[nodiscard]] in a bunch of places based on clang-tidy recomendations
eteran · Mar 18, 2024 · 51d10fe · 51d10fe
1 parent 7405b37
commit 51d10fe
Show file tree

Hide file tree

Showing 14 changed files with 35 additions and 35 deletions.
diff --git a/include/State.h b/include/State.h
@@ -53,18 +53,18 @@ class EDB_EXPORT State {
 	void swap(State &other);
 
 public:
-	QString flagsToString() const;
-	QString flagsToString(edb::reg_t flags) const;
-	Register value(const QString &reg) const;
-	Register instructionPointerRegister() const;
-	Register flagsRegister() const;
-	edb::address_t framePointer() const;
-	edb::address_t instructionPointer() const;
-	edb::address_t stackPointer() const;
-	edb::reg_t debugRegister(size_t n) const;
-	edb::reg_t flags() const;
-	Register gpRegister(size_t n) const;
-	Register archRegister(uint64_t type, size_t n) const;
+	[[nodiscard]] QString flagsToString() const;
+	[[nodiscard]] QString flagsToString(edb::reg_t flags) const;
+	[[nodiscard]] Register value(const QString &reg) const;
+	[[nodiscard]] Register instructionPointerRegister() const;
+	[[nodiscard]] Register flagsRegister() const;
+	[[nodiscard]] edb::address_t framePointer() const;
+	[[nodiscard]] edb::address_t instructionPointer() const;
+	[[nodiscard]] edb::address_t stackPointer() const;
+	[[nodiscard]] edb::reg_t debugRegister(size_t n) const;
+	[[nodiscard]] edb::reg_t flags() const;
+	[[nodiscard]] Register gpRegister(size_t n) const;
+	[[nodiscard]] Register archRegister(uint64_t type, size_t n) const;
 	void adjustStack(int bytes);
 	void clear();
 	bool empty() const;

diff --git a/plugins/Assembler/Assembler.h b/plugins/Assembler/Assembler.h
@@ -46,7 +46,7 @@ class Assembler : public QObject, public IPlugin {
 	void showDialog();
 
 private:
-	QPointer<QDialog> dialog_ = nullptr;
+	QPointer<QDialog> dialog_;
 };
 
 }

diff --git a/plugins/Backtrace/Backtrace.h b/plugins/Backtrace/Backtrace.h
@@ -45,7 +45,7 @@ public Q_SLOTS:
 
 private:
 	QMenu *menu_              = nullptr;
-	QPointer<QDialog> dialog_ = nullptr;
+	QPointer<QDialog> dialog_;
 };
 
 }

diff --git a/plugins/FunctionFinder/FunctionFinder.h b/plugins/FunctionFinder/FunctionFinder.h
@@ -44,8 +44,8 @@ public Q_SLOTS:
 	void showMenu();
 
 private:
-	QMenu *menu_              = nullptr;
-	QPointer<QDialog> dialog_ = nullptr;
+	QMenu *menu_ = nullptr;
+	QPointer<QDialog> dialog_;
 };
 
 }

diff --git a/plugins/HardwareBreakpoints/HardwareBreakpoints.h b/plugins/HardwareBreakpoints/HardwareBreakpoints.h
@@ -91,7 +91,7 @@ private Q_SLOTS:
 
 private:
 	QMenu *menu_              = nullptr;
-	QPointer<QDialog> dialog_ = nullptr;
+	QPointer<QDialog> dialog_;
 
 	QLineEdit *addresses_[4] = {};
 	QCheckBox *enabled_[4]   = {};

diff --git a/plugins/HeapAnalyzer/HeapAnalyzer.h b/plugins/HeapAnalyzer/HeapAnalyzer.h
@@ -44,8 +44,8 @@ public Q_SLOTS:
 	void showMenu();
 
 private:
-	QMenu *menu_              = nullptr;
-	QPointer<QDialog> dialog_ = nullptr;
+	QMenu *menu_ = nullptr;
+	QPointer<QDialog> dialog_;
 };
 
 }

diff --git a/plugins/OpcodeSearcher/OpcodeSearcher.h b/plugins/OpcodeSearcher/OpcodeSearcher.h
@@ -44,8 +44,8 @@ public Q_SLOTS:
 	void showMenu();
 
 private:
-	QMenu *menu_              = nullptr;
-	QPointer<QDialog> dialog_ = nullptr;
+	QMenu *menu_ = nullptr;
+	QPointer<QDialog> dialog_;
 };
 
 }

diff --git a/plugins/ProcessProperties/ProcessProperties.h b/plugins/ProcessProperties/ProcessProperties.h
@@ -43,8 +43,8 @@ public Q_SLOTS:
 	void showMenu();
 
 private:
-	QMenu *menu_              = nullptr;
-	QPointer<QDialog> dialog_ = nullptr;
+	QMenu *menu_ = nullptr;
+	QPointer<QDialog> dialog_;
 };
 
 }

diff --git a/plugins/ROPTool/ROPTool.h b/plugins/ROPTool/ROPTool.h
@@ -43,8 +43,8 @@ public Q_SLOTS:
 	void showMenu();
 
 private:
-	QMenu *menu_              = nullptr;
-	QPointer<QDialog> dialog_ = nullptr;
+	QMenu *menu_ = nullptr;
+	QPointer<QDialog> dialog_;
 };
 
 }

diff --git a/plugins/References/References.h b/plugins/References/References.h
@@ -45,7 +45,7 @@ public Q_SLOTS:
 
 private:
 	QMenu *menu_              = nullptr;
-	QPointer<QDialog> dialog_ = nullptr;
+	QPointer<QDialog> dialog_;
 };
 
 }

diff --git a/plugins/SymbolViewer/SymbolViewer.h b/plugins/SymbolViewer/SymbolViewer.h
@@ -44,8 +44,8 @@ public Q_SLOTS:
 	void showMenu();
 
 private:
-	QMenu *menu_              = nullptr;
-	QPointer<QDialog> dialog_ = nullptr;
+	QMenu *menu_ = nullptr;
+	QPointer<QDialog> dialog_;
 };
 
 }

diff --git a/src/Debugger.h b/src/Debugger.h
@@ -340,7 +340,7 @@ private Q_SLOTS:
 	std::shared_ptr<QHexView> stackView_;
 	std::shared_ptr<const IDebugEvent> lastEvent_;
 	std::unique_ptr<IBinary> binaryInfo_;
-	QPointer<QDialog> breakpointDialog_ = nullptr;
+	QPointer<QDialog> breakpointDialog_;
 
 private:
 	QAction *gotoAddressAction_;

diff --git a/src/capstone-edb/include/Formatter.h b/src/capstone-edb/include/Formatter.h
@@ -31,19 +31,19 @@ class EDB_EXPORT Formatter {
 	};
 
 public:
-	std::string toString(const Instruction &insn) const;
-	std::string toString(const Operand &operand) const;
-	std::string registerName(unsigned int reg) const;
+	[[nodiscard]] std::string toString(const Instruction &insn) const;
+	[[nodiscard]] std::string toString(const Operand &operand) const;
+	[[nodiscard]] std::string registerName(unsigned int reg) const;
 
-	FormatOptions options() const {
+	[[nodiscard]] FormatOptions options() const {
 		return options_;
 	}
 
 	void setOptions(const FormatOptions &options);
 
 private:
 	void checkCapitalize(std::string &str, bool canContainHex = true) const;
-	QString adjustInstructionText(const Instruction &insn) const;
+	[[nodiscard]] QString adjustInstructionText(const Instruction &insn) const;
 
 private:
 	FormatOptions options_ = {SyntaxIntel, LowerCase, false, true};

diff --git a/src/widgets/TabWidget.h b/src/widgets/TabWidget.h
@@ -33,7 +33,7 @@ class TabWidget : public QTabWidget {
 
 public:
 	void setData(int index, const QVariant &data);
-	QVariant data(int index) const;
+	[[nodiscard]] QVariant data(int index) const;
 
 protected:
 	void mousePressEvent(QMouseEvent *event) override;