Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable MESS #592

Merged
merged 9 commits into from
Dec 6, 2023
Merged

Disable MESS #592

merged 9 commits into from
Dec 6, 2023

Commits on Nov 29, 2023

  1. cmd/geth,cmd/utils,eth,eth/ethconfig,params/types/coregeth,params/typ…

    …es/ctypes,params/types/genesisT,params/types/goethereum: ECBP1100Disable: cli flag for override, config implementation
    
    Date: 2023-11-29 14:45:34-07:00
    Signed-off-by: meows <[email protected]>
    meowsbits committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    56f6679 View commit details
    Browse the repository at this point in the history
  2. params: configure ETC's ECBP1100Disable with FAKE block number

    Date: 2023-11-29 14:46:29-07:00
    Signed-off-by: meows <[email protected]>
    meowsbits committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    c29d869 View commit details
    Browse the repository at this point in the history
  3. params/types/coregeth,params/types/goethereum: implement ECBP1100Disa…

    …ble logic with runtime,reflection
    
    This may not be ideal from a CPU/time
    perspective (expected slow), but since
    this is likely a temporary code path
    as we expect to remove MESS code once
    the fork is passed, it may be sufficient,
    and is certainly a smaller change than
    adding -Disabled conditions at each
    occurrence of IsEnabled/ECBP1100 in the code.
    
    Date: 2023-11-29 15:52:37-07:00
    Signed-off-by: meows <[email protected]>
    meowsbits committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    9e274d0 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2023

  1. Configuration menu
    Copy the full SHA
    05877c4 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2023

  1. Configuration menu
    Copy the full SHA
    46d5236 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2023

  1. cmd/utils: these flags are not exclusive

    - 1100disable flag deactivates the feature
    - 1100.nodisable prevents safety mechanisms from
      toggling it once activated
    
    Date: 2023-12-06 07:11:04-07:00
    Signed-off-by: meows <[email protected]>
    meowsbits committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    0b1b8e1 View commit details
    Browse the repository at this point in the history
  2. core,eth,params/types/coregeth,params/types/ctypes,params/types/genes…

    …isT,params/types/goethereum: s/ECBP1100DisableTransition/ECBP1100DeactivateTransition/g
    
    The word Disable conflicts with the existing
    ECBP1100NoDisable flag and feature.
    That feature prevents the toggling of the ECBP1100
    feature per the safety mechanisms of low peer count
    and stale head.
    
    Renaming to Deactivate is intended to clarify
    the code usages.
    
    Based on feedback provided here #592 (comment)
    
    Date: 2023-12-06 07:21:58-07:00
    Signed-off-by: meows <[email protected]>
    
    cmd/geth,cmd/utils,core,eth,eth/ethconfig,params/types/coregeth: ECBP1100: s/enable/activate/g,s/disable/deactivate/g
    
    rename all references besides the method name
    
    Date: 2023-12-06 07:50:14-07:00
    Signed-off-by: meows <[email protected]>
    
    params,params/types/coregeth,params/types/goethereum: ECBP1100-deactivate: rename config fields s/disable/deactivate/g
    
    Date: 2023-12-06 08:07:08-07:00
    Signed-off-by: meows <[email protected]>
    
    core: (lint) remove unnecessary leading newline
    
    Date: 2023-12-06 08:09:00-07:00
    Signed-off-by: meows <[email protected]>
    
    params/types/goethereum: ECBP100: s/disableTransition/deactivateTransition/g
    
    Date: 2023-12-06 08:17:12-07:00
    Signed-off-by: meows <[email protected]>
    
    params/types/coregeth: ECBP100: s/disable/deactivate/g
    
    Date: 2023-12-06 08:19:09-07:00
    Signed-off-by: meows <[email protected]>
    meowsbits committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    e4b7dd2 View commit details
    Browse the repository at this point in the history
  3. cmd/geth,cmd/utils,eth,eth/ethconfig: ECBP100-deactivate: move overri…

    …de flags to --override.X,
    
    and categorize these flags.
    
    Date: 2023-12-06 08:02:58-07:00
    Signed-off-by: meows <[email protected]>
    meowsbits committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    84b98d9 View commit details
    Browse the repository at this point in the history
  4. params: ECBP1100(MESS): configure deactivation 19_250_000 == Spiral

    This configures the deactivation of MESS
    to coincide with the Spiral hardfork.
    
    Date: 2023-12-06 08:29:02-07:00
    Signed-off-by: meows <[email protected]>
    meowsbits committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    907295d View commit details
    Browse the repository at this point in the history