Merge/foundation release/1.13.4 to 1.13.1 #575
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* cmd/evm: improve flags handling This fixes some issues with flags in cmd/evm. The supported flags did not actually show up in help output because they weren't categorized. I'm also adding the VM-related flags to the run command here so they can be given after the subcommand name. So it can be run like this now: ./evm run --code 6001 --debug * cmd/evm: enable all forks by default in run command The default genesis was just empty with no forks at all, which is annoying because contracts will be relying on opcodes introduced in a fork. So this changes the default to have all forks enabled. * core/asm: fix some issues in the assembler This fixes minor bugs in the old assembler: - It is now possible to have comments on the same line as an instruction. - Errors for invalid numbers in the jump instruction are reported better - Line numbers in errors were off by one
This PR makes the tool use the --bootnodes list as the input to devp2p crawl. The flag will take effect if the input/output.json file is missing or empty.
There is no 0.0.3 release of karalabe/usb.
As the keydir will be automatically created after an account is created, no error message if the watcher is failed.
Avoid truncating files, if ancients are opened in readonly mode. With this change, we return error instead of trying (and failing) to repair
…(#28163) * trie: remove internal nodes between shortNode and child in path mode * trie: address comments * core/rawdb, trie: address comments * core/rawdb: delete unused func * trie: change comments * trie: add missing tests * trie: fix lint
This allows using the freezer from multiple processes at once in read-only mode. Co-authored-by: Martin Holst Swende <[email protected]>
When MatcherSession encounters an error, it attempts to close the session. Closing waits for all goroutines to finish, including the 'distributor'. However, the distributor will not exit until all requests have returned. This patch fixes the issue by delivering the (empty) result to the distributor before calling Close().
This fixes an issue where the --bootnodes flag was overridden by the config file. --------- Co-authored-by: NathanBSC <[email protected]> Co-authored-by: Felix Lange <[email protected]>
Co-authored-by: Felix Lange <[email protected]>
Adding a space beween function opOrigin() and opcCaller() in instruciton.go. Adding a space beween function opkeccak256() and opAddress() in instruciton.go.
This PR will allow a previously underpriced transaction back in after a timeout of 5 minutes. This will block most transaction spam but allow for transactions to be re-broadcasted on networks with less transaction flow. --------- Co-authored-by: Felix Lange <[email protected]>
So apparently in the spec the base block parameter of eth_call is optional. I agree that "latest" is a sane default for this that most people would use.
* eth/downloader: remove rollback mechanism in downloader * eth/downloader: remove the tests
core/txpool:fix typos
Errors returned from this function were getting ignored, resulting in silent-but-deadly startup errors, especially around authrpc, which is a relatively new addition, and the port collision of which causes a lot of people a lot of headaches. Date: 2023-11-01 07:51:52-06:00 Signed-off-by: meows <[email protected]>
….com/docker/docker-24.0.7incompatible build(deps): bump github.com/docker/docker from 20.10.24+incompatible to 24.0.7+incompatible
Bumps [github.com/consensys/gnark-crypto](https://github.com/consensys/gnark-crypto) from 0.10.0 to 0.12.0. - [Release notes](https://github.com/consensys/gnark-crypto/releases) - [Changelog](https://github.com/Consensys/gnark-crypto/blob/master/CHANGELOG.md) - [Commits](Consensys/gnark-crypto@v0.10.0...v0.12.0) --- updated-dependencies: - dependency-name: github.com/consensys/gnark-crypto dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
Date: 2023-11-01 08:31:57-06:00 Signed-off-by: meows <[email protected]>
node: return an error when node.startRPC returns one
This should have been tested already, but was overlooked. Tests are passing. Date: 2023-11-02 09:37:17-06:00 Signed-off-by: meows <[email protected]>
Being default-availble networks, they should have tests. Date: 2023-11-02 09:40:23-06:00 Signed-off-by: meows <[email protected]>
….com/consensys/gnark-crypto-0.12.0 build(deps): bump github.com/consensys/gnark-crypto from 0.10.0 to 0.12.0
Bumps [golang.org/x/image](https://github.com/golang/image) from 0.7.0 to 0.10.0. - [Commits](golang/image@v0.7.0...v0.10.0) --- updated-dependencies: - dependency-name: golang.org/x/image dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
….org/x/image-0.10.0 build(deps): bump golang.org/x/image from 0.7.0 to 0.10.0
Forkid tests
Signed-off-by: meows <[email protected]>
Signed-off-by: meows <[email protected]>
ziogaschr
commented
Nov 10, 2023
Conflicts:
core/forkid/forkid_test.go
go.mod
go.sum
ziogaschr
commented
Dec 5, 2023
ziogaschr
commented
Feb 2, 2024
|
I finished the review of the code. I will check back the comments and run a sync before accepting the PR. |
|
@meowsbits you have to manually delete edit: there is no reason for this to fail on GH actions |
…ethash,core,core/txpool/blobpool,core/txpool,core/types,core/vm,eth/catalyst,eth/protocols/eth,miner,params/types/coregeth,params/types/ctypes,params/types/genesisT,params/types/goethereum: add conditions per block number for cancun EIPs
ziogaschr
commented
Feb 8, 2024
ziogaschr
commented
Feb 8, 2024
…atherForks
forkid_test.go:563:40: not enough arguments in call to gatherForks
have (ctypes.ChainConfigurator)
want (ctypes.ChainConfigurator, uint64) (typecheck)
Signed-off-by: Diego López León <[email protected]>
|
Review done, closing in favor of #593. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.